question: array of custom objects validation not working

[Jrmyy]

Hi,

Validation for array of custom objects does not seem to work.

Versions:

class-transformer0.2.3
class-validator: 0.9.1

My objects:

questions.ts

export class QuestionsDto {
  @IsNotEmpty()
  @IsString()
  applicationId: string;

  @IsArray()
  @ValidateNested({each: true})
  @Type(() => QuestionDto)
  @ArrayMinSize(1)
  questions: QuestionDto[];
}

question.ts

export class QuestionDto {

  private static ALLOWED_QUESTION_TYPES = ['mcq', 'text', 'date'];

  @IsNotEmpty()
  @IsString()
  @IsIn(QuestionDto.ALLOWED_QUESTION_TYPES)
  type: string;

  @IsNotEmpty()
  @IsString()
  designation: string;

  @IsNotEmpty()
  @IsString()
  reason: string;

  @IsOptional()
  @IsArray()
  extraContent: string[];
}

Use case:

const q = {
  applicationId: 'aaa',
  questions: ['aaa']
}

const errors = validate(QuestionsDto, q)
console.log(errors.length)  // 0

Thanks by advance :)

[vlapo]

Hi problem is with arguments passed into validate function. You have to convert your plain json date q into instance of QuestionsDto and than use validate or validateSync:

const q = {
  applicationId: 'aaa',
  questions: ['aaa']
}

const errors = validate(QuestionsDto, q)
console.log(errors.length)  // 0

Also you shoud add IsInstance validator too. Correct example:

import 'reflect-metadata';
import { IsNotEmpty, IsArray, IsOptional, IsString, IsIn, ArrayMinSize, ValidateNested, validateSync, IsInstance, validate } from 'class-validator';
import { plainToClass, Type } from 'class-transformer'; 

export class QuestionDto {

  private static ALLOWED_QUESTION_TYPES = ['mcq', 'text', 'date'];

  @IsNotEmpty()
  @IsString()
  @IsIn(QuestionDto.ALLOWED_QUESTION_TYPES)
  type: string;

  @IsNotEmpty()
  @IsString()
  designation: string;

  @IsNotEmpty()
  @IsString()
  reason: string;

  @IsOptional()
  @IsArray()
  extraContent: string[];
}

class QuestionsDto {
  @IsNotEmpty()
  @IsString()
  applicationId: string;

  @IsArray()
  @ValidateNested({each: true})
  @Type(() => QuestionDto)
  @ArrayMinSize(1)
  @IsInstance(QuestionDto, {each: true})
  questions: QuestionDto[];
}

const q = {
  applicationId: 'aaa',
  questions: ['aaa']
}

const errors = validateSync(plainToClass(QuestionsDto, q));
console.log(errors)

[vlapo]

@Jrmyy Did you solve your problem?

[vlapo]

Closed for lack of response from reporter.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.