fix: MinDate & MaxDate constraint message unclear

[EmirBoyaci]

Closes: #1869

Description

See #1869

Checklist

• the pull request title describes what this PR does (not a vague title like Update index.md)
• the pull request targets the default branch of the repository (develop)
• the code follows the established code style of the repository
  • npm run prettier:check passes
  • npm run lint:check passes
• tests are added for the changes I made (if any source code was modified)
• documentation added or updated
• I have run the project locally and verified that there are no errors

Fixes

fixes #[issue number], fixes #[issue number]

[braaar]

Let's see what the workflows say, @NoNameProvided ?

[EmirBoyaci]

Let's see what the workflows say, @NoNameProvided ?

I think you need to approve again because I just merged develop to fix-1869 (it was outdated)

[EmirBoyaci]

I did not get the reason why it says "First-time contributors need a maintainer to approve running workflows. Learn more.". You have already approved but workflow did not started..

[braaar]

I did not get the reason why it says "First-time contributors need a maintainer to approve running workflows. Learn more.". You have already approved but workflow did not started..

I'm not a maintainer. I'm on the triage team and can close issues and pull requests, but not merge code or approve workflow runs.

[EmirBoyaci]

I did not get the reason why it says "First-time contributors need a maintainer to approve running workflows. Learn more.". You have already approved but workflow did not started..

I'm not a maintainer. I'm on the triage team and can close issues and pull requests, but not merge code or approve workflow runs.

Ah okay I see, so we'll wait until one maintainer approves 👍🏻

[CodyTseng]

class-validator/src/decorator/date/MinDate.ts

Lines 9 to 11 in 3f84de8

	export function minDate(date: unknown, minDate: Date | (() => Date)): boolean {
	return date instanceof Date && date.getTime() >= (minDate instanceof Date ? minDate : minDate()).getTime();
	}

class-validator/src/decorator/date/MaxDate.ts

Lines 9 to 11 in 3f84de8

	export function maxDate(date: unknown, maxDate: Date | (() => Date)): boolean {
	return date instanceof Date && date.getTime() <= (maxDate instanceof Date ? maxDate : maxDate()).getTime();
	}

It may be good to use isDate here to see whether passed prop is Date or Function like EmirBoyaci said above 😊

[EmirBoyaci]

Hi @braaar since it has ~2 months without activity, can I ask you to ping maintainer? I do not know who is responsible but since then only dependabot is bumping package versions..