Skip to content

Conversation

nolazybits
Copy link
Contributor

@nolazybits nolazybits commented Dec 8, 2020

Description

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes #[issue number], fixes #[issue number]

@nolazybits
Copy link
Contributor Author

I have a bit of a weird one here
running the npm run lint:check locally brings no error but there are some error on the CI ...
:/

@nolazybits nolazybits changed the title test: update project tooling chore: update project tooling Dec 8, 2020
@nolazybits
Copy link
Contributor Author

OK done

Copy link
Member

@jotamorais jotamorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a "big splash" PR to review but a well worth it.

Huge thanks to @d0ck, @NoNameProvided and @nolazybits for the commits, tests and PR.

@jotamorais jotamorais merged commit d8bde3c into typestack:develop Dec 10, 2020
@nolazybits nolazybits deleted the feat/update-project-tooling branch December 10, 2020 21:44
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants