Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum git version not checked #844

Closed
therealgilles opened this issue Jan 25, 2021 · 7 comments
Closed

Minimum git version not checked #844

therealgilles opened this issue Jan 25, 2021 · 7 comments

Comments

@therealgilles
Copy link

@therealgilles therealgilles commented Jan 25, 2021

Husky v5 does not check that git is at least 2.9. I was trying to install it with 2.8.1, nothing got installed but no errors were reported. It even tried to git commit my staged files.

@typicode
Copy link
Owner

@typicode typicode commented Jan 26, 2021

Thanks for the feedback. Out of curiosity what's the OS used, is it the default version?

@therealgilles
Copy link
Author

@therealgilles therealgilles commented Jan 26, 2021

I'm running Mac OS Big Sur 11.2 beta but I'm not sure Apple ships git with it.
It's possible I had not run brew update in a while, or that I had not run 'brew link --overwrite git' and /usr/local/bin/git was still pointing to the 2.8.1 version. Having a package install run 'git commit' without an explanation is very disconcerting.

@typicode
Copy link
Owner

@typicode typicode commented Jan 26, 2021

Ok, I think I better understand the issue. I'll fix that 👍

@typicode
Copy link
Owner

@typicode typicode commented Jan 28, 2021

Should be good in v5.0.8

@therealgilles
Copy link
Author

@therealgilles therealgilles commented Jan 28, 2021

Could be useful to mention in a comment to check the git version maybe?

@typicode
Copy link
Owner

@typicode typicode commented Jan 28, 2021

Agree, I'll add that to the docs.

@typicode
Copy link
Owner

@typicode typicode commented Jan 28, 2021

I've updated the troubleshoot section with Git version requirement 👍

@typicode typicode closed this Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment