Skip to content

Commit 19d2d71

Browse files
garvinhickingsbuerk
authored andcommitted
[TASK] Isolate functional test fixture assets for EXT:frontend
This patch removes fixture cross-dependencies from EXT:frontend to EXT:core. The existing "pages_frontend.csv" file is identical to the Core's "pages.csv" Fixture and can be switched. A very simple Fluid Partial (one liner) is copied to be distinct to EXT:frontend. Assets are copied to be unique and prevent side-effects when files are changed at their original location. Tests should be side-effect free and isolated. Remaining exemption for cross-dependencies are references to: EXT:core/Tests/Functional/Fixtures/Frontend/JsonRenderer.typoscript EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_csv EXT:core/Tests/Functional/Fixtures/Extensions/test_eid EXT:core/Tests/Functional/Fixtures/Extensions/test_classic_content EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mm EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnsymmetric EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributeinline EXT:core/Tests/Functional/Fixtures/Extensions/test_irre_mnattributesimple These central fixtures should not be redundantly stored, and are fittingly placed in the "EXT:core" space. Releases: main, 13.4 Resolves: #105900 Related: #105899 Related: #105901 Related: #105902 Change-Id: I475edaae8d9c266a2cc3c4adbbd927adcb96856d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87671 Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Stefan Bürk <stefan@buerk.tech>
1 parent 281b0af commit 19d2d71

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{results -> f:format.json() -> f:format.raw()}

typo3/sysext/frontend/Tests/Functional/Rendering/AbsoluteUriPrefixRenderingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ final class AbsoluteUriPrefixRenderingTest extends FunctionalTestCase
7474
protected function setUp(): void
7575
{
7676
parent::setUp();
77-
$this->importCsvDataSet(__DIR__ . '/../../../../core/Tests/Functional/Fixtures/pages.csv');
77+
$this->importCsvDataSet(__DIR__ . '/../Fixtures/pages_frontend.csv');
7878
$this->writeSiteConfiguration(
7979
'test',
8080
$this->buildSiteConfiguration(1, 'http://localhost/'),

typo3/sysext/frontend/Tests/Functional/Rendering/ScriptAndLinkTagRenderingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ final class ScriptAndLinkTagRenderingTest extends FunctionalTestCase
5757
protected function setUp(): void
5858
{
5959
parent::setUp();
60-
$this->importCsvDataSet(__DIR__ . '/../../../../core/Tests/Functional/Fixtures/pages.csv');
60+
$this->importCsvDataSet(__DIR__ . '/../Fixtures/pages_frontend.csv');
6161
$this->writeSiteConfiguration(
6262
'test',
6363
$this->buildSiteConfiguration(1, '/'),

typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ final class UriPrefixRenderingTest extends FunctionalTestCase
7373
protected function setUp(): void
7474
{
7575
parent::setUp();
76-
$this->importCsvDataSet(__DIR__ . '/../../../../core/Tests/Functional/Fixtures/pages.csv');
76+
$this->importCsvDataSet(__DIR__ . '/../Fixtures/pages_frontend.csv');
7777
$this->writeSiteConfiguration(
7878
'test',
7979
$this->buildSiteConfiguration(1, '/'),

typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ protected function createHierarchicalMenuProcessorInstruction(array $typoScript)
138138
->withArray([
139139
'10' => 'FLUIDTEMPLATE',
140140
'10.' => [
141-
'file' => 'typo3/sysext/core/Tests/Functional/Fixtures/Frontend/FluidJson.html',
141+
'file' => 'typo3/sysext/frontend/Tests/Functional/Fixtures/Frontend/FluidJson.html',
142142
'dataProcessing.' => [
143143
'1' => 'TYPO3\\CMS\\Frontend\\DataProcessing\\MenuProcessor',
144144
'1.' => array_merge(
@@ -156,7 +156,7 @@ protected function createLanguageMenuProcessorInstruction(array $typoScript): Ar
156156
->withArray([
157157
'10' => 'FLUIDTEMPLATE',
158158
'10.' => [
159-
'file' => 'typo3/sysext/core/Tests/Functional/Fixtures/Frontend/FluidJson.html',
159+
'file' => 'typo3/sysext/frontend/Tests/Functional/Fixtures/Frontend/FluidJson.html',
160160
'dataProcessing.' => [
161161
'1' => 'TYPO3\\CMS\\Frontend\\DataProcessing\\LanguageMenuProcessor',
162162
'1.' => array_merge(

0 commit comments

Comments
 (0)