[TASK] Allow floats for TCA type number range values

If the field is using `format=decimal` the range should be allowed to be
defined as floats as well.

Resolves: #101812
Releases: main, 13.4, 12.4
Change-Id: I64adb0336075dbce333807e8060cd72620693205
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85187
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Garvin Hicking <gh@faktor-e.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: Benni Mack <benni@typo3.org>

Author: georgringer

typo3/sysext/backend/Classes/Form/Element/NumberElement.php

@@ -188,8 +188,8 @@ public function render(): array
             $rangeAttributes = [
                 'type' => 'range',
                 'class' => 'form-range-input',
-                'min' => (string)(int)($config['range']['lower'] ?? 0),
-                'max' => (string)(int)($config['range']['upper'] ?? 10000),
+                'min' => (string)(float)($config['range']['lower'] ?? 0),
+                'max' => (string)(float)($config['range']['upper'] ?? 10000),
                 'step' => (string)($config['slider']['step'] ?? 1),
                 'style' => 'width: ' . (int)($config['slider']['width'] ?? 400) . 'px',
                 'title' => (string)$itemValue,
@@ -214,10 +214,10 @@ public function render(): array
         $resultArray = $this->mergeChildReturnIntoExistingResult($resultArray, $fieldWizardResult, false);
 
         if (isset($config['range']['lower'])) {
-            $attributes['min'] = (string)(int)$config['range']['lower'];
+            $attributes['min'] = (string)(float)$config['range']['lower'];
         }
         if (isset($config['range']['upper'])) {
-            $attributes['max'] = (string)(int)$config['range']['upper'];
+            $attributes['max'] = (string)(float)$config['range']['upper'];
         }
 
         if ($format === 'decimal') {

typo3/sysext/core/Classes/DataHandling/DataHandler.php

@@ -1693,11 +1693,20 @@ protected function checkValueForNumber(mixed $value, array $tcaFieldConf): array
 
         // Checking range of value:
         if (is_array($tcaFieldConf['range'] ?? false)) {
-            if (isset($tcaFieldConf['range']['upper']) && ceil($result['value']) > (int)$tcaFieldConf['range']['upper']) {
-                $result['value'] = (int)$tcaFieldConf['range']['upper'];
-            }
-            if (isset($tcaFieldConf['range']['lower']) && floor($result['value']) < (int)$tcaFieldConf['range']['lower']) {
-                $result['value'] = (int)$tcaFieldConf['range']['lower'];
+            if ($format === 'decimal') {
+                if (isset($tcaFieldConf['range']['upper']) && ceil((float)$result['value']) > (float)$tcaFieldConf['range']['upper']) {
+                    $result['value'] = (float)$tcaFieldConf['range']['upper'];
+                }
+                if (isset($tcaFieldConf['range']['lower']) && floor((float)$result['value']) < (float)$tcaFieldConf['range']['lower']) {
+                    $result['value'] = (float)$tcaFieldConf['range']['lower'];
+                }
+            } else {
+                if (isset($tcaFieldConf['range']['upper']) && ceil($result['value']) > (int)$tcaFieldConf['range']['upper']) {
+                    $result['value'] = (int)$tcaFieldConf['range']['upper'];
+                }
+                if (isset($tcaFieldConf['range']['lower']) && floor($result['value']) < (int)$tcaFieldConf['range']['lower']) {
+                    $result['value'] = (int)$tcaFieldConf['range']['lower'];
+                }
             }
         }
 

typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php

@@ -357,7 +357,7 @@ public static function inputValuesRangeDoubleDataProvider(): array
             ],
             '"-0.5" is interpreted correctly as -0.5 but is lower than 0 and set to 0' => [
                 '-0.5',
-                0,
+                0.0,
             ],
             '"0.5" is interpreted correctly as 0.5 and is equal to 0.5' => [
                 '0.5',
@@ -367,16 +367,16 @@ public static function inputValuesRangeDoubleDataProvider(): array
                 '39.9',
                 '39.90',
             ],
-            '"42.3" is interpreted correctly as 42.3 but is greater then 42 and set to 42' => [
-                '42.3',
-                42,
+            '"43.3" is interpreted correctly as 43.3 but is greater then 42 and set to 42' => [
+                '43.3',
+                42.0,
             ],
         ];
     }
 
     #[DataProvider('inputValuesRangeDoubleDataProvider')]
     #[Test]
-    public function inputValueCheckRespectsRightLowerAndUpperLimitForDouble(string $value, string|int $expectedReturnValue): void
+    public function inputValueCheckRespectsRightLowerAndUpperLimitForDouble(string $value, string|int|float $expectedReturnValue): void
     {
         $tcaFieldConf = [
             'type' => 'number',
@@ -392,7 +392,7 @@ public function inputValueCheckRespectsRightLowerAndUpperLimitForDouble(string $
 
     #[DataProvider('inputValuesRangeDoubleDataProvider')]
     #[Test]
-    public function inputValueCheckRespectsRightLowerAndUpperLimitWithDefaultValueForDouble(string $value, string|int $expectedReturnValue): void
+    public function inputValueCheckRespectsRightLowerAndUpperLimitWithDefaultValueForDouble(string $value, string|int|float $expectedReturnValue): void
     {
         $tcaFieldConf = [
             'type' => 'number',

typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php

@@ -791,8 +791,8 @@
                 'format' => 'decimal',
                 'size' => 5,
                 'range' => [
-                    'lower' => -90,
-                    'upper' => 90,
+                    'lower' => -90.5,
+                    'upper' => 90.5,
                 ],
                 'default' => 14.5,
                 'slider' => [