[TASK] Remove unused properties in PageRenderer

PageRenderer properties jsFooterLibs, jsFooterInline and
jsFooterFiles are never evaluated but handed
in in some places.

They can be removed, as it makes further changes in this
class or the refactoring of the hooks easier.

Resolves: #107682
Releases: main
Change-Id: Icadb087c0c11d17a9af5b5bbc638616a7e82f06d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91024
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>

Author: bmack

typo3/sysext/core/Classes/Page/PageRenderer.php

@@ -60,14 +60,12 @@ class PageRenderer implements SingletonInterface
      */
     protected Locale $locale;
 
-    // Arrays containing associative array for the included files
+    // Arrays containing associative arrays for the included files
     /**
      * @var array<string, array>
      */
     protected array $jsFiles = [];
-    protected array $jsFooterFiles = [];
     protected array $jsLibs = [];
-    protected array $jsFooterLibs = [];
 
     /**
      * @var array<string, array>
@@ -101,7 +99,6 @@ class PageRenderer implements SingletonInterface
      * @var array<string, array>
      */
     protected array $jsInline = [];
-    protected array $jsFooterInline = [];
 
     /**
      * @var array<string, array>
@@ -227,9 +224,7 @@ protected function reset(): void
         $this->templateFile = 'EXT:core/Resources/Private/Templates/PageRenderer.html';
         $this->bodyContent = '';
         $this->jsFiles = [];
-        $this->jsFooterFiles = [];
         $this->jsInline = [];
-        $this->jsFooterInline = [];
         $this->jsLibs = [];
         $this->cssFiles = [];
         $this->cssInline = [];
@@ -1888,18 +1883,19 @@ protected function doConcatenateJavaScript()
         }
         if (!empty($GLOBALS['TYPO3_CONF_VARS']['FE']['jsConcatenateHandler'])) {
             // use external concatenation routine
+            // @todo: $jsFooterFiles can be removed once the hook is adapted / replaced
+            $jsFooterFiles = [];
             $params = [
                 'jsLibs' => &$this->jsLibs,
                 'jsFiles' => &$this->jsFiles,
-                'jsFooterFiles' => &$this->jsFooterFiles,
+                'jsFooterFiles' => &$jsFooterFiles,
                 'headerData' => &$this->headerData,
                 'footerData' => &$this->footerData,
             ];
             GeneralUtility::callUserFunction($GLOBALS['TYPO3_CONF_VARS']['FE']['jsConcatenateHandler'], $params, $this);
         } else {
             $this->jsLibs = $this->resourceCompressor->concatenateJsFiles($this->jsLibs);
             $this->jsFiles = $this->resourceCompressor->concatenateJsFiles($this->jsFiles);
-            $this->jsFooterFiles = $this->resourceCompressor->concatenateJsFiles($this->jsFooterFiles);
         }
     }
 
@@ -1978,12 +1974,14 @@ protected function doCompressJavaScript()
         }
         if (!empty($GLOBALS['TYPO3_CONF_VARS']['FE']['jsCompressHandler'])) {
             // Use external compression routine
+            // @todo: $jsFooterFiles and $jsFooterInline and $jsFooterLibs can be removed once the hook is adapted / replaced
+            $jsFooterFiles = $jsFooterInline = [];
             $params = [
                 'jsInline' => &$this->jsInline,
-                'jsFooterInline' => &$this->jsFooterInline,
+                'jsFooterInline' => &$jsFooterInline,
                 'jsLibs' => &$this->jsLibs,
                 'jsFiles' => &$this->jsFiles,
-                'jsFooterFiles' => &$this->jsFooterFiles,
+                'jsFooterFiles' => &$jsFooterFiles,
                 'headerData' => &$this->headerData,
                 'footerData' => &$this->footerData,
             ];
@@ -1997,7 +1995,6 @@ protected function doCompressJavaScript()
             }
             $this->jsLibs = $this->resourceCompressor->compressJsFiles($this->jsLibs);
             $this->jsFiles = $this->resourceCompressor->compressJsFiles($this->jsFiles);
-            $this->jsFooterFiles = $this->resourceCompressor->compressJsFiles($this->jsFooterFiles);
         }
     }
 
@@ -2043,17 +2040,19 @@ protected function executePreRenderHook()
         if (!$hooks) {
             return;
         }
+        // @todo: $jsFooterFiles and $jsFooterInline and $jsFooterLibs can be removed once the hook is adapted / replaced
+        $jsFooterFiles = $jsFooterLibs = $jsFooterInline = [];
         $params = [
             'jsLibs' => &$this->jsLibs,
-            'jsFooterLibs' => &$this->jsFooterLibs,
+            'jsFooterLibs' => &$jsFooterLibs,
             'jsFiles' => &$this->jsFiles,
-            'jsFooterFiles' => &$this->jsFooterFiles,
+            'jsFooterFiles' => &$jsFooterFiles,
             'cssLibs' => &$this->cssLibs,
             'cssFiles' => &$this->cssFiles,
             'headerData' => &$this->headerData,
             'footerData' => &$this->footerData,
             'jsInline' => &$this->jsInline,
-            'jsFooterInline' => &$this->jsFooterInline,
+            'jsFooterInline' => &$jsFooterInline,
             'cssInline' => &$this->cssInline,
         ];
         foreach ($hooks as $hook) {
@@ -2070,17 +2069,19 @@ protected function executeRenderPostTransformHook()
         if (!$hooks) {
             return;
         }
+        // @todo: $jsFooterFiles and $jsFooterInline and $jsFooterLibs can be removed once the hook is adapted / replaced
+        $jsFooterFiles = $jsFooterLibs = $jsFooterInline = [];
         $params = [
             'jsLibs' => &$this->jsLibs,
-            'jsFooterLibs' => &$this->jsFooterLibs,
+            'jsFooterLibs' => &$jsFooterLibs,
             'jsFiles' => &$this->jsFiles,
-            'jsFooterFiles' => &$this->jsFooterFiles,
+            'jsFooterFiles' => &$jsFooterFiles,
             'cssLibs' => &$this->cssLibs,
             'cssFiles' => &$this->cssFiles,
             'headerData' => &$this->headerData,
             'footerData' => &$this->footerData,
             'jsInline' => &$this->jsInline,
-            'jsFooterInline' => &$this->jsFooterInline,
+            'jsFooterInline' => &$jsFooterInline,
             'cssInline' => &$this->cssInline,
         ];
         foreach ($hooks as $hook) {