[!!!][TASK] Avoid global content link rewriting in FE

The frontend rendering contains a method that receives
the fully generated Response body content to apply a
global search and replace string operation in order
to fix links to included assets.

This was always a bad idea and is now finally obsolete
with the new system resource API: The system can expect
that links to resources are final when they are created
by some sub system.

The patch removes the logic along with a TYPO3_CONF_VARS
setting that allowed exending this brittle magic.

Resolves: #108114
Related: #107537
Releases: main
Change-Id: Ib67aad945475a93e774338c621df6a5641e5f36d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/91656
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Lina Wolf <112@linawolf.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Lina Wolf <112@linawolf.de>
Tested-by: Helmut Hummel <typo3@helhum.io>

Author: lolli42

typo3/sysext/core/Configuration/DefaultConfiguration.php

@@ -1553,7 +1553,6 @@
         'defaultTypoScript_constants.' => [], // Lines of TS to include after a static template with the uid = the index in the array (Constants)
         'defaultTypoScript_setup' => '',
         'defaultTypoScript_setup.' => [], // Lines of TS to include after a static template with the uid = the index in the array (Setup)
-        'additionalAbsRefPrefixDirectories' => '',
         'enable_mount_pids' => true,
         'hidePagesIfNotTranslatedByDefault' => false,
         'eID_include' => [], // Array of key/value pairs where key is "tx_[ext]_[optional suffix]" and value is relative filename of class to include. Key is used as "?eID=" for \TYPO3\CMS\Frontend\Http\RequestHandlerRequestHandler to include the code file which renders the page from that point. (Useful for functionality that requires a low initialization footprint, eg. frontend ajax applications)

typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml

@@ -520,9 +520,6 @@ FE:
             type: multiline
             description: 'Enter lines of default TypoScript, setup-field.'
             compareValuesWithCurrentConfiguration: false
-        additionalAbsRefPrefixDirectories:
-            type: text
-            description: 'Enter additional directories to be prepended with absRefPrefix. Directories must be comma-separated. TYPO3 already prepends the following directories: typo3/, typo3temp/, typo3conf/ext/ and all local storages'
         enable_mount_pids:
             type: bool
             description: 'If enabled, the mount_pid feature allowing ''symlinks'' in the page tree (for frontend operation) is allowed.'

typo3/sysext/core/Documentation/Changelog/14.0/Breaking-108114-GlobalFrontendContentLinkPrefixingRemoved.rst

@@ -0,0 +1,57 @@
+..  include:: /Includes.rst.txt
+
+..  _breaking-108114-1763085569:
+
+==================================================================
+Breaking: #108114 - Global frontend content link prefixing removed
+==================================================================
+
+See :issue:`108114`
+
+Description
+===========
+
+The frontend rendering contained logic that searched for links to resources within
+the generated Response content to globally replace them with the configured URL
+prefix (TypoScript :typoscript:`config.absRefPrefix`).
+
+This solution has always been brittle and has finally been obsoleted with the
+introduction of the :ref:`system resource API <feature-107537-1759136314>`.
+
+The global search and replace code has been removed which obsoletes setting
+:php:`$GLOBALS['TYPO3_CONF_VARS']['FE']['additionalAbsRefPrefixDirectories']`
+as well.
+
+
+Impact
+======
+
+Generated content can no longer expect their links to resources being globally
+"fixed". They need to create the final URL themself.
+
+The obsolete :php:`$GLOBALS['TYPO3_CONF_VARS']['FE']['additionalAbsRefPrefixDirectories']`
+will be automatically removed from :file:`settings.php` after upgrading to
+TYPO3 v14 and accessing the install tool.
+
+
+Affected installations
+======================
+
+The system resource API is wired into the system in a way that extensions usually
+create proper links automatically as long as the provided core API is used.
+
+Instances with extensions that hard code link generation may be affected, though.
+
+
+Migration
+=========
+
+Instances should check the rendered frontend for broken links after upgrading
+to TYPO3 v14 and substitute hard coded link generation with proper API calls,
+for instance based on the various URL, URI and asset related Fluid view helpers.
+
+This change heavily depends on the specific extension code. There is no
+good advise for extension developers to catch all possible cases.
+
+
+..  index:: Frontend, PHP-API, NotScanned, ext:frontend

typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php

@@ -25,21 +25,18 @@
 use TYPO3\CMS\Core\Cache\CacheTag;
 use TYPO3\CMS\Core\Cache\Frontend\FrontendInterface;
 use TYPO3\CMS\Core\Context\Context;
-use TYPO3\CMS\Core\Core\Environment;
 use TYPO3\CMS\Core\Database\ConnectionPool;
 use TYPO3\CMS\Core\Page\AssetCollector;
 use TYPO3\CMS\Core\Page\PageRenderer;
 use TYPO3\CMS\Core\PageTitle\PageTitleProviderManager;
 use TYPO3\CMS\Core\TimeTracker\TimeTracker;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Core\Utility\PathUtility;
 use TYPO3\CMS\Frontend\Authentication\FrontendBackendUserAuthentication;
 use TYPO3\CMS\Frontend\Cache\CacheLifetimeCalculator;
 use TYPO3\CMS\Frontend\Cache\MetaDataState;
 use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
 use TYPO3\CMS\Frontend\Event\AfterCacheableContentIsGeneratedEvent;
 use TYPO3\CMS\Frontend\Event\AfterCachedPageIsPersistedEvent;
-use TYPO3\CMS\Frontend\Page\FrontendUrlPrefix;
 
 /**
  * Main controller class of the TypoScript based frontend.
@@ -175,8 +172,6 @@ protected function setSysLastChanged(ServerRequestInterface $request): void
      */
     public function generatePage_postProcessing(ServerRequestInterface $request, string $content): string
     {
-        $absRefPrefix = GeneralUtility::makeInstance(FrontendUrlPrefix::class)->getUrlPrefix($request);
-        $content = $this->setAbsRefPrefixInContent($content, $absRefPrefix);
         $eventDispatcher = GeneralUtility::makeInstance(EventDispatcherInterface::class);
         $usePageCache = $request->getAttribute('frontend.cache.instruction')->isCachingAllowed();
         $cacheDataCollector = $request->getAttribute('frontend.cache.collector');
@@ -318,8 +313,6 @@ public function INTincScript(ServerRequestInterface $request, string $content):
         $content = $pageRenderer->renderJavaScriptAndCssForProcessingOfUncachedContentObjects($content, $pageParts->getPageRendererSubstitutionHash());
         // Replace again, because header and footer data and page renderer replacements may introduce additional placeholders (see #44825)
         $content = $this->recursivelyReplaceIntPlaceholdersInContent($request, $content);
-        $absRefPrefix = GeneralUtility::makeInstance(FrontendUrlPrefix::class)->getUrlPrefix($request);
-        $content = $this->setAbsRefPrefixInContent($content, $absRefPrefix);
         $this->getTimeTracker()->pull();
         return $content;
     }
@@ -546,36 +539,6 @@ public function isStaticCacheble(ServerRequestInterface $request): bool
         return $isCachingAllowed && !$pageParts->hasNotCachedContentElements() && !$this->context->getAspect('frontend.user')->isUserOrGroupSet();
     }
 
-    /**
-     * Converts relative paths in the HTML source to absolute paths for fileadmin/, typo3conf/ext/ and media/ folders.
-     */
-    protected function setAbsRefPrefixInContent(string $content, string $absRefPrefix): string
-    {
-        if ($absRefPrefix === '') {
-            return $content;
-        }
-        $encodedAbsRefPrefix = htmlspecialchars($absRefPrefix, ENT_QUOTES | ENT_HTML5);
-        $search = [
-            '"_assets/',
-            '"typo3temp/',
-            '"' . PathUtility::stripPathSitePrefix(Environment::getExtensionsPath()) . '/',
-            '"' . PathUtility::stripPathSitePrefix(Environment::getFrameworkBasePath()) . '/',
-        ];
-        $replace = [
-            '"' . $encodedAbsRefPrefix . '_assets/',
-            '"' . $encodedAbsRefPrefix . 'typo3temp/',
-            '"' . $encodedAbsRefPrefix . PathUtility::stripPathSitePrefix(Environment::getExtensionsPath()) . '/',
-            '"' . $encodedAbsRefPrefix . PathUtility::stripPathSitePrefix(Environment::getFrameworkBasePath()) . '/',
-        ];
-        // Process additional directories
-        $directories = GeneralUtility::trimExplode(',', $GLOBALS['TYPO3_CONF_VARS']['FE']['additionalAbsRefPrefixDirectories'], true);
-        foreach ($directories as $directory) {
-            $search[] = '"' . $directory;
-            $replace[] = '"' . $encodedAbsRefPrefix . $directory;
-        }
-        return str_replace($search, $replace, $content);
-    }
-
     /**
      * Get the cache timeout for the current page.
      */

typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php

@@ -213,6 +213,8 @@ class SilentConfigurationUpgradeService
         'BE/compressionLevel',
         // #108055
         'FE/compressionLevel',
+        // #108114
+        'FE/additionalAbsRefPrefixDirectories',
     ];
 
     public function __construct(private readonly ConfigurationManager $configurationManager) {}