[TASK] Avoid some useless test assertions

PSR-7 MessageInterface forces getHeader(): array,
there is no point in asserting this in tests.
Avoiding this makes phpstan more happy.

Resolves: #105684
Releases: main, 13.4
Change-Id: Ib85188734f2240c88489c1480297b1e3eba38bc1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87192
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Andreas Nedbal <andy@pixelde.su>
Reviewed-by: Andreas Nedbal <andy@pixelde.su>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>

Author: lolli42

Build/phpstan/phpstan-baseline.neon

@@ -4842,12 +4842,6 @@ parameters:
 			count: 1
 			path: ../../typo3/sysext/redirects/Tests/Functional/EventListener/AddPageTypeZeroSourceTest.php
 
-		-
-			message: '#^Call to static method PHPUnit\\Framework\\Assert\:\:assertIsArray\(\) with array\<string\> will always evaluate to true\.$#'
-			identifier: staticMethod.alreadyNarrowedType
-			count: 16
-			path: ../../typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php
-
 		-
 			message: '#^Call to function is_array\(\) with array will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType

typo3/sysext/redirects/Tests/Functional/Service/RedirectServiceTest.php

@@ -176,8 +176,6 @@ public function checkReponseCodeOnRedirect($url, $statusCode, $targetUrl, $redir
             new InternalRequest($url)
         );
         self::assertEquals($statusCode, $response->getStatusCode());
-        self::assertIsArray($response->getHeader('X-Redirect-By'));
-        self::assertIsArray($response->getHeader('location'));
         self::assertEquals('TYPO3 Redirect ' . $redirectUid, $response->getHeader('X-Redirect-By')[0]);
         self::assertEquals($targetUrl, $response->getHeader('location')[0]);
     }
@@ -325,8 +323,6 @@ public function checkRegExpRedirects(string $url, int $expectedStatusCode, strin
             false
         );
         self::assertEquals($expectedStatusCode, $response->getStatusCode());
-        self::assertIsArray($response->getHeader('X-Redirect-By'));
-        self::assertIsArray($response->getHeader('location'));
         self::assertEquals('TYPO3 Redirect ' . $expectedRedirectUid, $response->getHeader('X-Redirect-By')[0]);
         self::assertEquals($expectedRedirectUri, $response->getHeader('location')[0]);
     }
@@ -383,8 +379,6 @@ public function regexpWithNoParamRegexpAndRespectingGetParameteresRedirectsIfNoP
             false
         );
         self::assertSame($expectedStatusCode, $response->getStatusCode());
-        self::assertIsArray($response->getHeader('X-Redirect-By'));
-        self::assertIsArray($response->getHeader('location'));
         self::assertSame('TYPO3 Redirect ' . $expectedRedirectUid, $response->getHeader('X-Redirect-By')[0]);
         self::assertSame($expectedRedirectUri, $response->getHeader('location')[0]);
     }
@@ -540,8 +534,6 @@ public function samePathWithSameDomainT3Target(string $url, string $baseUri, int
         );
         self::assertEquals($expectedStatusCode, $response->getStatusCode());
         if ($expectedRedirectUri) {
-            self::assertIsArray($response->getHeader('X-Redirect-By'));
-            self::assertIsArray($response->getHeader('location'));
             self::assertEquals('TYPO3 Redirect ' . $expectedRedirectUid, $response->getHeader('X-Redirect-By')[0]);
             self::assertEquals($expectedRedirectUri, $response->getHeader('location')[0]);
         }
@@ -683,8 +675,6 @@ public function samePathWithSameDomainAndRelativeTarget(string $url, string $bas
         );
         self::assertEquals($expectedStatusCode, $response->getStatusCode());
         if ($expectedRedirectUri) {
-            self::assertIsArray($response->getHeader('X-Redirect-By'));
-            self::assertIsArray($response->getHeader('location'));
             self::assertEquals('TYPO3 Redirect ' . $expectedRedirectUid, $response->getHeader('X-Redirect-By')[0]);
             self::assertEquals($expectedRedirectUri, $response->getHeader('location')[0]);
         }
@@ -846,8 +836,6 @@ public function samePathRedirectsWithExternalTarget(string $url, string $baseUri
         );
         self::assertEquals($expectedStatusCode, $response->getStatusCode());
         if ($expectedRedirectUri) {
-            self::assertIsArray($response->getHeader('X-Redirect-By'));
-            self::assertIsArray($response->getHeader('location'));
             self::assertEquals('TYPO3 Redirect ' . $expectedRedirectUid, $response->getHeader('X-Redirect-By')[0]);
             self::assertEquals($expectedRedirectUri, $response->getHeader('location')[0]);
         }
@@ -964,8 +952,6 @@ public function regExpRedirectsWithArgumentMatchesWithSimilarRegExpWithoutQueryP
             new InternalRequest($url)
         );
         self::assertEquals($statusCode, $response->getStatusCode());
-        self::assertIsArray($response->getHeader('X-Redirect-By'));
-        self::assertIsArray($response->getHeader('location'));
         self::assertEquals('TYPO3 Redirect ' . $redirectUid, $response->getHeader('X-Redirect-By')[0]);
         self::assertEquals($targetUrl, $response->getHeader('location')[0]);
     }
@@ -1076,8 +1062,6 @@ public function sourceHostNotNotContainedInAnySiteConfigRedirectIsRedirected(
 
         $response = $this->executeFrontendSubRequest($request);
         self::assertEquals($expectedRedirectStatusCode, $response->getStatusCode());
-        self::assertIsArray($response->getHeader('X-Redirect-By'));
-        self::assertIsArray($response->getHeader('location'));
         self::assertEquals('TYPO3 Redirect ' . $expectedRedirectUid, $response->getHeader('X-Redirect-By')[0]);
         self::assertEquals($expectedRedirectLocationUri, $response->getHeader('location')[0]);
     }