[!!!][TASK] Remove deprecated methods in TypoScriptFrontendController

The following PHP class methods that have previously been marked as
deprecated for v13 have been removed in class
`\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController`:

- `addCacheTags()`
- `getPageCacheTags()`

Resolves: #105460
Related: #105377
Related: #102422
Releases: main
Change-Id: I9c24f68e6b697e76c2cfc5bd721027ce176b30ed
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86775
Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com>

Author: thomashohn

typo3/sysext/core/Documentation/Changelog/14.0/Breaking-105377-DeprecatedFunctionalityRemoved.rst

@@ -91,6 +91,8 @@ The following PHP class methods that have previously been marked as deprecated w
 - :php:`\TYPO3\CMS\Fluid\View\FluidViewAdapter->setTemplateRootPaths()`
 - :php:`\TYPO3\CMS\Fluid\View\FluidViewAdapter->setTemplateSource()`
 - :php:`\TYPO3\CMS\Fluid\View\TemplatePaths->fillDefaultsByPackageName()`
+- :php:`\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController->addCacheTags()`
+- :php:`\TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController->getPageCacheTags()`
 - :php:`\TYPO3\CMS\Frontend\Page\PageRepository->enableFields()`
 
 The following PHP static class methods that have previously been marked as deprecated for v13 have been removed:

typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php

@@ -405,37 +405,6 @@ protected function setSysLastChanged(ServerRequestInterface $request): void
         }
     }
 
-    /**
-     * Adds tags to this page's cache entry, you can then f.e. remove cache
-     * entries by tag
-     *
-     * @param array $tags An array of tag
-     * @deprecated since TYPO3 v13, will be removed in TYPO3 v14. Use $request->getAttribute('frontend.cache.collector')->addCacheTags(new CacheTag($tag, $lifetime)) instead.
-     */
-    public function addCacheTags(array $tags)
-    {
-        trigger_error(
-            'TypoScriptFrontendController->addCacheTags has been marked as deprecated in TYPO3 v13. Use $request->getAttribute(\'frontend.cache.collector\')->addCacheTags(new CacheTag($tag, $lifetime)) instead.',
-            E_USER_DEPRECATED,
-        );
-        $cacheDataCollector = $GLOBALS['TYPO3_REQUEST']->getAttribute('frontend.cache.collector');
-        $cacheDataCollector->addCacheTags(...array_map(fn(string $tag) => new CacheTag($tag), $tags));
-    }
-
-    /**
-     * @return array
-     * @deprecated since TYPO3 v13, will be removed in TYPO3 v14. Use $request->getAttribute('frontend.cache.collector')->getCacheTags() instead.
-     */
-    public function getPageCacheTags(): array
-    {
-        trigger_error(
-            'TypoScriptFrontendController->getPageCacheTags has been marked as deprecated in TYPO3 v13. Use $request->getAttribute(\'frontend.cache.collector\')->getCacheTags() instead.',
-            E_USER_DEPRECATED,
-        );
-        $cacheDataCollector = $GLOBALS['TYPO3_REQUEST']->getAttribute('frontend.cache.collector');
-        return array_map(fn(CacheTag $cacheTag) => $cacheTag->name, $cacheDataCollector->getCacheTags());
-    }
-
     /**
      * Sets up TypoScript "config." options and set properties in $TSFE.
      *

typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php

@@ -6372,13 +6372,15 @@
         'maximumNumberOfArguments' => 1,
         'restFiles' => [
             'Deprecation-102422-TypoScriptFrontendController-addCacheTags.rst',
+            'Breaking-105377-DeprecatedFunctionalityRemoved.rst',
         ],
     ],
     'TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController->getPageCacheTags' => [
         'numberOfMandatoryArguments' => 0,
         'maximumNumberOfArguments' => 0,
         'restFiles' => [
             'Deprecation-102422-TypoScriptFrontendController-addCacheTags.rst',
+            'Breaking-105377-DeprecatedFunctionalityRemoved.rst',
         ],
     ],
 ];