Skip to content

Commit af94dd2

Browse files
linawolflolli42
authored andcommitted
[TASK] Unify backend labels for file mounts
This change standardizes backend labels related to file mounts, ensuring a more professional and internationally consistent terminology across affected modules. The term "filemount" is less common in english than in german, so it has been adjusted to "file mount" for better readability and alignment with english conventions. Additionally, all relevant comments in PHP code have been updated to maintain consistency in how the term is written. Resolves: #106123 Releases: main, 13.4 Change-Id: I771e50a58e3346a8629de1aacb6eaeed99317fd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88098 Tested-by: core-ci <typo3@b13.com> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Garvin Hicking <gh@faktor-e.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech>
1 parent 92bc8d4 commit af94dd2

File tree

23 files changed

+70
-70
lines changed

23 files changed

+70
-70
lines changed

typo3/sysext/backend/Classes/Tree/FileStorageTreeProvider.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ public function getSubfoldersRecursively(Folder $folderObject, int $currentDepth
230230
}
231231

232232
/**
233-
* Fetches all "root level folders" of a storage. If a user has filemounts in this storage, they are properly resolved.
233+
* Fetches all "root level folders" of a storage. If a user has file mounts in this storage, they are properly resolved.
234234
*
235235
* @return array|array[]
236236
*/

typo3/sysext/backend/Classes/View/FolderUtilityRenderer.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public function __construct(LinkParameterProviderInterface $parameterProvider)
4747
}
4848

4949
/**
50-
* For TBE: Makes a form for creating new folders in the filemount the user is browsing.
50+
* For TBE: Makes a form for creating new folders in the file mount the user is browsing.
5151
* The folder creation request is sent to the tce_file.php script in the core which will handle the creation.
5252
*
5353
* @param Folder $folderObject Absolute filepath on server in which to create the new folder.
@@ -91,7 +91,7 @@ public function createFolder(ServerRequestInterface $request, Folder $folderObje
9191
}
9292

9393
/**
94-
* Makes an upload form for uploading files to the filemount the user is browsing.
94+
* Makes an upload form for uploading files to the file mount the user is browsing.
9595
* The files are uploaded to the tce_file.php script in the core which will handle the upload.
9696
*
9797
* @return string HTML for an upload form.

typo3/sysext/beuser/Classes/Domain/Model/FileMount.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,12 @@ class FileMount extends AbstractEntity
4141
protected string $description = '';
4242

4343
/**
44-
* Identifier of the filemount
44+
* Identifier of the file mount
4545
*/
4646
protected string $identifier = '';
4747

4848
/**
49-
* Status of the filemount
49+
* Status of the file mount
5050
*/
5151
protected bool $hidden = false;
5252

@@ -124,7 +124,7 @@ public function setHidden(bool $hidden): void
124124
}
125125

126126
/**
127-
* returns the path segment of the filemount (without the storage id)
127+
* returns the path segment of the file mount (without the storage id)
128128
*/
129129
public function getPath(): string
130130
{

typo3/sysext/beuser/README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ compare the settings of backend users and verify their permissions. This module
1010
also displays any backend users who are currently logged in.
1111

1212
Additionally it is possible to display a list / add / delete / modify
13-
filemounts in a separate submodule.
13+
file mounts in a separate submodule.
1414

1515
:Repository: https://github.com/typo3/typo3
1616
:Issues: https://forge.typo3.org/

typo3/sysext/beuser/Resources/Private/Language/locallang.xlf

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -356,33 +356,33 @@
356356
<source>Compare backend user groups</source>
357357
</trans-unit>
358358

359-
<!-- Filemounts -->
359+
<!-- File mounts -->
360360
<trans-unit id="filemounts">
361-
<source>Filemounts</source>
361+
<source>File mounts</source>
362362
</trans-unit>
363363
<trans-unit id="filemount.list.title">
364-
<source>Filemounts</source>
364+
<source>File Mounts</source>
365365
</trans-unit>
366366
<trans-unit id="filemount.confirm.deletion">
367-
<source>Are you sure, that you want to delete the filemount "%s"?</source>
367+
<source>Are you sure, that you want to delete the file mount "%s"?</source>
368368
</trans-unit>
369369
<trans-unit id="filemount.create">
370-
<source>Create new filemount</source>
370+
<source>Create new file mount</source>
371371
</trans-unit>
372372
<trans-unit id="filemount.infobox.noFilemountFound.title">
373-
<source>No filemount found</source>
373+
<source>No file mount found</source>
374374
</trans-unit>
375375
<trans-unit id="filemount.infobox.noFilemountFound.message">
376-
<source>Please create a filemount and select its entry point.</source>
376+
<source>Please create a file mount and select its entry point.</source>
377377
</trans-unit>
378378
<trans-unit id="filemount.link.openInFilelist">
379379
<source>Open in file list</source>
380380
</trans-unit>
381381
<trans-unit id="filemount.amount.multiple">
382-
<source>Filemounts</source>
382+
<source>File mounts</source>
383383
</trans-unit>
384384
<trans-unit id="filemount.amount.singular">
385-
<source>Filemount</source>
385+
<source>File mount</source>
386386
</trans-unit>
387387

388388
<!-- Password reset -->

typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,7 +1175,7 @@ protected function initializeFileStorages()
11751175
$this->fileStorages[$storageObject->getUid()] = $storageObject;
11761176
}
11771177
} else {
1178-
// Regular users only have storages that are defined in their filemounts
1178+
// Regular users only have storages that are defined in their file mounts
11791179
// Permissions and file mounts for the storage are added in StoragePermissionAspect
11801180
foreach ($this->getFileMountRecords() as $row) {
11811181
if (!str_contains($row['identifier'] ?? '', ':')) {
@@ -1326,7 +1326,7 @@ public function getFileMountRecords()
13261326
}
13271327
}
13281328

1329-
// Personal or Group filemounts are not accessible if file mount list is set in workspace record
1329+
// Personal or Group file mounts are not accessible if file mount list is set in workspace record
13301330
if ($this->workspace <= 0 || empty($this->workspaceRec['file_mountpoints'])) {
13311331
// If userHomePath is set, we attempt to mount it
13321332
if ($GLOBALS['TYPO3_CONF_VARS']['BE']['userHomePath'] ?? false) {
@@ -1385,9 +1385,9 @@ public function getFileMountRecords()
13851385
}
13861386

13871387
/**
1388-
* Returns an array with the filemounts for the user.
1389-
* Each filemount is represented with an array of a "name", "path" and "type".
1390-
* If no filemounts an empty array is returned.
1388+
* Returns an array with the file mounts for the user.
1389+
* Each file mount is represented with an array of a "name", "path" and "type".
1390+
* If no file mounts an empty array is returned.
13911391
*
13921392
* @return \TYPO3\CMS\Core\Resource\ResourceStorage[]
13931393
*/

typo3/sysext/core/Classes/Resource/Driver/DriverInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ public function dumpFileContents(string $identifier): void;
338338
*
339339
* Hint: this also needs to return TRUE if the given identifier
340340
* matches the container identifier to allow access to the root
341-
* folder of a filemount.
341+
* folder of a file mount.
342342
*
343343
* @param non-empty-string $folderIdentifier
344344
* @param non-empty-string $identifier identifier to be checked against $folderIdentifier

typo3/sysext/core/Classes/Resource/Folder.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public function getName(): string
110110
public function getReadablePath($rootId = null)
111111
{
112112
if ($rootId === null) {
113-
// Find first matching filemount and use that as root
113+
// Find first matching file mount and use that as root
114114
foreach ($this->storage->getFileMounts() as $fileMount) {
115115
if ($this->storage->isWithinFolder($fileMount['folder'], $this)) {
116116
$rootId = $fileMount['folder']->getIdentifier();

typo3/sysext/core/Classes/Resource/ResourceStorage.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
* As all requests have to run through the storage, the storage knows about the
121121
* permissions of a BE/FE user, the file permissions / limitations of the driver
122122
* and has some configurable capabilities.
123-
* Additionally, a BE user can use "filemounts" (known from previous installations)
123+
* Additionally, a BE user can use "file mounts" (known from previous installations)
124124
* to limit his/her work-zone to only a subset (identifier and its subfolders/subfolders)
125125
* of the user itself.
126126
*
@@ -154,7 +154,7 @@ class ResourceStorage implements ResourceStorageInterface
154154
protected bool $evaluatePermissions = false;
155155

156156
/**
157-
* User filemounts, added as an array, and used as filters
157+
* User file mounts, added as an array, and used as filters
158158
*/
159159
protected array $fileMounts = [];
160160

@@ -536,7 +536,7 @@ public function markAsTemporaryOffline()
536536
* User Permissions / File Mounts
537537
********************************/
538538
/**
539-
* Adds a filemount as a "filter" for users to only work on a subset of a
539+
* Adds a file mount as a "filter" for users to only work on a subset of a
540540
* storage object
541541
*
542542
* @param string $folderIdentifier
@@ -546,10 +546,10 @@ public function markAsTemporaryOffline()
546546
*/
547547
public function addFileMount($folderIdentifier, $additionalData = [])
548548
{
549-
// check for the folder before we add it as a filemount
549+
// check for the folder before we add it as a file mount
550550
if ($this->driver->folderExists($folderIdentifier) === false) {
551551
// if there is an error, this is important and should be handled
552-
// as otherwise the user would see the whole storage without any restrictions for the filemounts
552+
// as otherwise the user would see the whole storage without any restrictions for the file mounts
553553
throw new FolderDoesNotExistException('Folder for file mount ' . $folderIdentifier . ' does not exist.', 1334427099);
554554
}
555555
$data = $this->driver->getFolderInfoByIdentifier($folderIdentifier);
@@ -2607,7 +2607,7 @@ public function isWithinFolder(Folder $folder, ResourceInterface $resource)
26072607
* or the first mount point of this storage for this user
26082608
* if $respectFileMounts is set.
26092609
*
2610-
* @todo: this is a bad method design, because the calling code can never fetch all filemounts nor traverse them.
2610+
* @todo: this is a bad method design, because the calling code can never fetch all file mounts nor traverse them.
26112611
*/
26122612
public function getRootLevelFolder(bool $respectFileMounts = true): Folder
26132613
{

typo3/sysext/core/Classes/Type/Bitmask/BackendGroupMountOption.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
/**
2323
* A class providing constants for bitwise operations on whether backend users
24-
* should add / inherit the DB mounts / File Mounts from
24+
* should add / inherit the DB mounts / file mounts from
2525
*/
2626
final class BackendGroupMountOption extends BitSet
2727
{

0 commit comments

Comments
 (0)