[BUGFIX] Add specific file link generator for ext:styleguide

TCA-Examples inside EXT:styleguide provide generated example data
to demonstrate functionality. Up until now, no specified generator
option could be applied to fields defined as
`type=link` and `allowedFileExtensions` applied,
meaning the link for a file should be created.
This was a simple web page link until now, which
did not reflect the wanted behaviour.

A new generator is now introduced, providing links to the example
files ext:styleguide ships.

Resolves: #104224
Releases: main, 13.4
Change-Id: I304f9c20501068e118464cf614f0da9da310efd9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84932
Tested-by: Garvin Hicking <gh@faktor-e.de>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Garvin Hicking <gh@faktor-e.de>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Sebastian Iffland <sebastian.iffland@fullhaus.de>

Author: Philipp Kuhlmay

typo3/sysext/styleguide/Classes/TcaDataGenerator/FieldGenerator/TypeLinkFile.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the TYPO3 CMS project.
+ *
+ * It is free software; you can redistribute it and/or modify it under
+ * the terms of the GNU General Public License, either version 2
+ * of the License, or any later version.
+ *
+ * For the full copyright and license information, please read the
+ * LICENSE.txt file that was distributed with this source code.
+ *
+ * The TYPO3 project - inspiring people to share!
+ */
+
+namespace TYPO3\CMS\Styleguide\TcaDataGenerator\FieldGenerator;
+
+use TYPO3\CMS\Core\LinkHandling\FileLinkHandler;
+use TYPO3\CMS\Styleguide\TcaDataGenerator\FieldGeneratorInterface;
+use TYPO3\CMS\Styleguide\TcaDataGenerator\RecordFinder;
+
+/**
+ * Generate data for type=link fields, where allowed type is file only
+ *
+ * @internal
+ */
+final class TypeLinkFile extends AbstractFieldGenerator implements FieldGeneratorInterface
+{
+    protected array $matchArray = [
+        'fieldConfig' => [
+            'config' => [
+                'type' => 'link',
+                'allowedTypes' => ['file'],
+            ],
+        ],
+    ];
+
+    public function __construct(
+        private readonly RecordFinder $recordFinder,
+        private readonly FileLinkHandler $fileLinkHandler
+    ) {}
+
+    public function generate(array $data): string
+    {
+        $demoImages = $this->recordFinder->findDemoFileObjects();
+        $image = next($demoImages);
+        return $this->fileLinkHandler->asString(['file' => $image]);
+    }
+}

typo3/sysext/styleguide/Configuration/Services.yaml

@@ -63,6 +63,9 @@ services:
         # General type=datetime generator
         - '@TYPO3\CMS\Styleguide\TcaDataGenerator\FieldGenerator\TypeDatetime'
 
+        # Specific type=link generator
+        - '@TYPO3\CMS\Styleguide\TcaDataGenerator\FieldGenerator\TypeLinkFile'
+
         # General type=link generator
         - '@TYPO3\CMS\Styleguide\TcaDataGenerator\FieldGenerator\TypeLink'
 

typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php

@@ -531,12 +531,12 @@
         ],
         'link_2' => [
             'label' => 'link_2',
-            'description' => 'type=link allowedTypes=file allowedOptions=allowedFileExtensions=png',
+            'description' => 'type=link allowedTypes=file allowedOptions=allowedFileExtensions=jpg,png',
             'config' => [
                 'type' => 'link',
                 'allowedTypes' => ['file'],
                 'appearance' => [
-                    'allowedFileExtensions' => ['png'],
+                    'allowedFileExtensions' => ['jpg', 'png'],
                 ],
             ],
         ],