[BUGFIX] Ensure trailing slash for PAGEVIEW paths

Since `paths` are used to generate paths for partials and layouts,
it must be ensured that each path ends with a slash.

Resolves: #105646
Releases: main, 13.4
Change-Id: I296e2571082fb15d324155f6cf822dfdf4be7bba
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/87156
Reviewed-by: Andreas Nedbal <andy@pixelde.su>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Simon Praetorius <simon@praetorius.me>
Reviewed-by: Simon Praetorius <simon@praetorius.me>
Tested-by: Andreas Nedbal <andy@pixelde.su>

Author: s2b

typo3/sysext/frontend/Classes/ContentObject/PageViewContentObject.php

@@ -19,6 +19,7 @@
 
 use TYPO3\CMS\Core\Page\PageLayoutResolver;
 use TYPO3\CMS\Core\TypoScript\TypoScriptService;
+use TYPO3\CMS\Core\Utility\PathUtility;
 use TYPO3\CMS\Core\View\ViewFactoryData;
 use TYPO3\CMS\Core\View\ViewFactoryInterface;
 use TYPO3\CMS\Frontend\ContentObject\Exception\ContentRenderingException;
@@ -83,14 +84,15 @@ public function render($conf = []): string
                 1724601907
             );
         }
+        $paths = array_map(PathUtility::sanitizeTrailingSeparator(...), $conf['paths.']);
         $viewFactoryData = new ViewFactoryData(
             // @todo: Do discuss: Rename 'paths.' to 'templateRootPaths.' again?
-            templateRootPaths: $conf['paths.'],
+            templateRootPaths: $paths,
             // @todo: We should *still* allow setting both partialRootPaths and layoutRootPaths, and only fall back to
             //        [templateRootPaths]/Partials and [templateRootPaths]/Layouts if not set. And the fallback should be
             //        advertised as best practice.
-            partialRootPaths: array_map(static fn(string $path): string => $path . 'Partials/', $conf['paths.']),
-            layoutRootPaths: array_map(static fn(string $path): string => $path . 'Layouts/', $conf['paths.']),
+            partialRootPaths: array_map(static fn(string $path): string => $path . 'Partials/', $paths),
+            layoutRootPaths: array_map(static fn(string $path): string => $path . 'Layouts/', $paths),
             request: $this->request,
         );
         $view = $this->viewFactory->create($viewFactoryData);

typo3/sysext/frontend/Tests/Functional/ContentObject/PageViewContentObjectTest.php

@@ -96,4 +96,18 @@ public function assignReservedVariableNameInTypoScriptThrowsInvalidArgumentExcep
         self::expectExceptionMessage(sprintf('Cannot use reserved name "%s" as variable name in PAGEVIEW.', $variableName));
         $this->executeFrontendSubRequest((new InternalRequest())->withPageId(self::ROOT_PAGE_ID));
     }
+
+    #[Test]
+    public function pathsCanBeSpecifiedWithoutTrailingSlash(): void
+    {
+        $this->setUpFrontendRootPage(
+            self::ROOT_PAGE_ID,
+            [
+                'EXT:frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Configuration/TypoScript/withoutTrailingSlash.typoscript',
+            ]
+        );
+        $response = $this->executeFrontendSubRequest((new InternalRequest())->withPageId(self::ROOT_PAGE_ID));
+        self::assertStringContainsString('You are on page Fluid Root Page', (string)$response->getBody());
+        self::assertStringContainsString('This is content from the test partial.', (string)$response->getBody());
+    }
 }

typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Configuration/TypoScript/withoutTrailingSlash.typoscript

@@ -0,0 +1,4 @@
+page = PAGE
+page.10 = PAGEVIEW
+page.10.paths.100 = EXT:test_fluidpagerendering/Resources/Private/Templates
+

typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/Templates/Pages/Standard.html

@@ -3,4 +3,5 @@
 <f:section name="content">
     This is a standard page with no content.
     page-layout-identifier-{page.pageLayout.identifier}
+    <f:render partial="TestPartial" />
 </f:section>

typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_fluidpagerendering/Resources/Private/Templates/Partials/TestPartial.html

@@ -0,0 +1 @@
+This is content from the test partial.