[BUGFIX] Always use getProcessedValue for detail view in Workspace Module

This change ensures to always have the full row (versioned / live)
to do a comparison in the workspaces module DetailView.

This allows to use getProcessedValue() which e.g. resolves
the proper colPos title when moving a content element into
a different colPos with a custom backend layout.

Resolves: #91667
Releases: main, 13.4
Change-Id: I2135cffa44c4ce4103ea2d2e6a802870c8653488
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89092
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Benni Mack <benni@typo3.org>

Author: bmack

typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php

@@ -124,8 +124,8 @@ public function getRowDetails(\stdClass $parameter): array
         $schema = $this->tcaSchemaFactory->get($table);
         $diffReturnArray = [];
         $liveReturnArray = [];
-        $liveRecord = (array)BackendUtility::getRecord($table, $parameter->t3ver_oid);
-        $versionRecord = (array)BackendUtility::getRecord($table, $parameter->uid);
+        $plainLiveRecord = $liveRecord = (array)BackendUtility::getRecord($table, $parameter->t3ver_oid);
+        $plainVersionRecord = $versionRecord = (array)BackendUtility::getRecord($table, $parameter->uid);
         $versionState = VersionState::tryFrom($versionRecord['t3ver_state'] ?? 0);
         $iconWorkspace = $this->iconFactory->getIconForRecord($table, $versionRecord, IconSize::SMALL);
         $stagePosition = $this->stagesService->getPositionOfCurrentStage($parameter->stage);
@@ -137,6 +137,7 @@ public function getRowDetails(\stdClass $parameter): array
                 continue;
             }
             // Disable internal fields
+            // l10n_diffsource is not needed, see #91667
             if ($schema->isLanguageAware() && $schema->getCapability(TcaSchemaCapability::Language)->getDiffSourceField()?->getName() === $fieldName) {
                 continue;
             }
@@ -207,7 +208,7 @@ public function getRowDetails(\stdClass $parameter): array
                     ];
                 } elseif ($isNewOrDeletePlaceholder && isset($suitableFields[$fieldName])) {
                     // If this is a new or delete placeholder, add diff view for all appropriate fields
-                    $newOrDeleteRecord[$fieldName] = $this->formatValue($table, $fieldName, (string)$liveRecord[$fieldName], $liveRecord['uid'], $configuration);
+                    $newOrDeleteRecord[$fieldName] = $this->formatValue($table, $fieldName, (string)$liveRecord[$fieldName], $liveRecord['uid'], $configuration, $plainLiveRecord);
 
                     // Don't add empty fields
                     if ($newOrDeleteRecord[$fieldName] === '') {
@@ -230,8 +231,8 @@ public function getRowDetails(\stdClass $parameter): array
                     ];
                 } elseif ((string)$liveRecord[$fieldName] !== (string)$versionRecord[$fieldName]) {
                     // Select the human-readable values before diff
-                    $liveRecord[$fieldName] = $this->formatValue($table, $fieldName, (string)$liveRecord[$fieldName], $liveRecord['uid'], $configuration);
-                    $versionRecord[$fieldName] = $this->formatValue($table, $fieldName, (string)$versionRecord[$fieldName], $versionRecord['uid'], $configuration);
+                    $liveRecord[$fieldName] = $this->formatValue($table, $fieldName, (string)$liveRecord[$fieldName], $liveRecord['uid'], $configuration, $plainLiveRecord);
+                    $versionRecord[$fieldName] = $this->formatValue($table, $fieldName, (string)$versionRecord[$fieldName], $versionRecord['uid'], $configuration, $plainVersionRecord);
                     $fieldDifferences = $this->diffUtility->diff(strip_tags($liveRecord[$fieldName]), strip_tags($versionRecord[$fieldName]), $granularity);
                     $diffReturnArray[] = [
                         'field' => $fieldName,
@@ -298,12 +299,12 @@ public function getRowDetails(\stdClass $parameter): array
         ];
     }
 
-    protected function formatValue(string $table, string $fieldName, string $value, int $uid, array $tcaConfiguration): string
+    protected function formatValue(string $table, string $fieldName, string $value, int $uid, array $tcaConfiguration, array $fullRow): string
     {
         if (($tcaConfiguration['type'] ?? '') === 'flex') {
             return $this->flexFormValueFormatter->format($table, $fieldName, $value, $uid, $tcaConfiguration);
         }
-        return (string)BackendUtility::getProcessedValue($table, $fieldName, $value, 0, true, false, $uid);
+        return (string)BackendUtility::getProcessedValue($table, $fieldName, $value, 0, true, false, $uid, true, (int)$fullRow['pid'], $fullRow);
     }
 
     /**