[BUGFIX] Always set the validator for an argument in extbase

Fix also a wrong annotation for initialize methods.

This patch will also remove two entries in the phpstan baseline.

Resolves: #106310
Releases: main
Change-Id: I3a2c845ab6c248cd6b56d43f9400185e5150cdff
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88496
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>

Author: simonschaufi

Build/phpstan/phpstan-baseline.neon

@@ -2280,18 +2280,6 @@ parameters:
 			count: 1
 			path: ../../typo3/sysext/extbase/Classes/Annotation/IgnoreValidation.php
 
-		-
-			message: '#^Call to function is_callable\(\) with callable\(\)\: mixed will always evaluate to true\.$#'
-			identifier: function.alreadyNarrowedType
-			count: 1
-			path: ../../typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php
-
-		-
-			message: '#^Strict comparison using \!\=\= between TYPO3\\CMS\\Extbase\\Validation\\Validator\\ConjunctionValidator and null will always evaluate to true\.$#'
-			identifier: notIdentical.alwaysTrue
-			count: 1
-			path: ../../typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php
-
 		-
 			message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#'
 			identifier: function.alreadyNarrowedType

typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php

@@ -328,9 +328,7 @@ public function initializeControllerArgumentsBaseValidators(): void
                 $argument->getDataType(),
                 $this->request
             );
-            if ($validator !== null) {
-                $argument->setValidator($validator);
-            }
+            $argument->setValidator($validator);
         }
     }
 
@@ -352,7 +350,7 @@ public function processRequest(RequestInterface $request): ResponseInterface
         $this->fileHandlingService->initializeFileUploadConfigurationsFromRequest($request, $this->arguments);
         $this->initializeAction();
         $actionInitializationMethodName = 'initialize' . ucfirst($this->actionMethodName);
-        /** @var callable $callable */
+        /** @var callable|null $callable */
         $callable = [$this, $actionInitializationMethodName];
         if (is_callable($callable)) {
             $callable();