chore: make SSG favicon replaceable #315
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR makes the SSG favicon replaceable by allowing users to provide their own favicon.png file instead of using a hardcoded one.
- Adds documentation explaining that users can provide a custom favicon.png in the public directory
- Updates gitignore to exclude the favicon.png file from version control
- Modifies the symlink task to create a symbolic link for the favicon.png file
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| website/typst-docs-web/README.md | Documents the new favicon customization feature |
| website/typst-docs-web/.gitignore | Excludes favicon.png from version control |
| mise.toml | Adds favicon.png symlink creation to the build task |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
12 tasks
|
Could you please do a quick review? @YDX-2147483647 |
ultimatile
approved these changes
Sep 20, 2025
YDX-2147483647
approved these changes
Sep 20, 2025
gomazarashi
approved these changes
Sep 20, 2025
kimushun1101
approved these changes
Sep 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. #233 (comment)