-
Notifications
You must be signed in to change notification settings - Fork 13
chore: make SSG Git submodule #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR converts the /website/typst-docs-web/
directory from a direct code implementation to a Git submodule, simplifying repository management by referencing an external repository for the SSG (Static Site Generator) codebase.
- Removes all TypeScript/JavaScript SSG implementation files from the main repository
- Adds
typst-docs-web
as a Git submodule pointing to an external repository - Updates documentation to explain the submodule structure and initialization process
Reviewed Changes
Copilot reviewed 74 out of 81 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
.gitmodules | Configures the new Git submodule for typst-docs-web |
website/typst-docs-web | Replaces the directory with a submodule reference |
website/README.md | Documents the new submodule structure and initialization steps |
CONTRIBUTING.md | Updates contribution guidelines to include --recursive flag for cloning |
Multiple SSG files | Removes all TypeScript/React SSG implementation files (vite.config.ts, src/*, etc.) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご対応いただきありがとうございます。動作確認できました。
補助的なコメントを入れました。
Co-authored-by: Shunsuke KIMURA <kimushun1101@gmail.com>
となってビルドできなかったのですが、
こうですね |
CIとローカル環境のどちらでも動作確認ができているのですが、詳しい状況を教えてもらえますか? 考えられる可能性としては、Git submoduleが初期化できておらず、シンボリックリンクの作成先パスの親ディレクトリが存在しないことによるエラーかもしれません。以下のコマンドを実行し、 git submodule update --init --recursive |
すみません、やり直したら何もしていないのに直りました、なんだったのでしょう... |
cf. #233
変更点
/website/typst-docs-web/
ディレクトリをGit submoduleに変更した