Skip to content

Conversation

abhishekj720
Copy link
Contributor

What changed?
Added logs to scanWorflow methods.

We need these logs to debug the issues with internal shadower.

Why?

Adding it to check what query has been passed and has been broken in the process.
When running shadower, it says invalid query. So, adding this will tell where the problem is.
How did you test it?
Just adding logs. Will be adding the tests in later diffs.

Potential risks
N/A, as these are just few logs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2444

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 61.996%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/WorkflowThreadImpl.java 1 77.32%
src/main/java/com/uber/cadence/internal/replay/DecisionStateMachineBase.java 3 61.18%
src/main/java/com/uber/cadence/internal/replay/ActivityDecisionContext.java 5 89.72%
Totals Coverage Status
Change from base Build 2433: 0.04%
Covered Lines: 12091
Relevant Lines: 19503

💛 - Coveralls

@agautam478 agautam478 merged commit db1dbca into master Aug 1, 2024
@abhishekj720 abhishekj720 deleted the logShadow2 branch August 1, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants