This repository was archived by the owner on Mar 7, 2019. It is now read-only.
Test almost everything #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Increased coverage 9% 😎 |
Contributor
Author
visualization/visualization_test.go
Outdated
Contributor
There was a problem hiding this comment.
may want to check errors here
Contributor
Author
There was a problem hiding this comment.
If os.Getwd() fails then runPerlScript is going to propagate the error when it also calls os.Getwd(). Hence, this test will fail even if I don't check errors here.
Contributor
There was a problem hiding this comment.
sure, i just mean it's bad form to discard errors, and you would want to fail fast here to indicate that something is messed up with your test environment
Contributor
|
looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added osWrapper struct to visualization.go and main.go to wrap Go os and exec functions. This enables much more test mocking.