Use url.URL to create the pprof URL

[prashantv]

To avoid issues like #20, we can use url.URL to create the final URL.

r @sandlerben

[sandlerben]

This is a great idea. Is it typical to write test cases which call other test cases?

[prashantv]

Yep, table tests are more common, but parameterized tests are also common, e.g.
https://github.com/golang/go/blob/master/src/unicode/utf8/utf8_test.go#L222

In general, we should avoid code duplication, as long as the test is still readable and obvious.

[sandlerben]

@prashantv The coverage went down just because we added one more

if err != nil { 
    log.Fatal(err)
} 

It's frustrating that we can't test that log.Fatal happens. Do you think it would be worthwhile to wrap goTorchCommand inside a function like commandAction so that goTorchCommand would return errors and we would log.Fatal inside commandAction?

[prashantv]

@sandlerben re: coverage, I think it's worth considering moving away from the cli package. It overcomplicates the design and makes it harder to write code that just returns err, where you only have a log.Fatal once.

cli is great when you have a complex cli with multiple commands that have different flags etc. However, go-torch only has a single command, so I think you could write a vastly simplified CLI using:
https://github.com/jessevdk/go-flags

Your main function would parse the options and pass an options struct, and you would have a function like

func run(opts *Options) error {

}

It would be strongly typed to pass arguments in tests, the function is a simple interface that returns errors that can be tested, and I think the overall amount of code would be less.

This is a much bigger change, but it might be worth trying out.

[sandlerben]

@prashantv Interesting proposal. I'll look into that when I have some time.