Skip to content
This repository was archived by the owner on Mar 7, 2019. It is now read-only.

Conversation

@calavera
Copy link
Contributor

Hi!

I added a couple of changes to the project:

  1. A brand new Dockerfile, so people can use go-torch from within
    a docker container using docker run uber/go-torch go-torch ...
  2. I removed the old Godeps file and added Glide files as requested.

@sandlerben
Copy link
Contributor

I've been using Godep for vendoring and it's been working quite well. Do you like bmizerany/vendor better?

@calavera
Copy link
Contributor Author

It's much more simple to use since it leaves all the dependency loading to Go's new vendoring

@sandlerben
Copy link
Contributor

Cool!

@prashantv
Copy link
Contributor

Thanks for the change @calavera. The docker file seems great.

A couple of things:

  1. Can you please fill out the Uber Contributor License Agreement
  2. Rather than vendor, we prefer to use glide, and only check in the glide.yaml and glide.lock.

Signed-off-by: David Calavera <david.calavera@gmail.com>
@calavera calavera force-pushed the dockerfile branch 2 times, most recently from 4036c99 to ae306e3 Compare March 28, 2016 23:50
@calavera calavera changed the title Add dockerfile and use Go 1.6 vendor. Add dockerfile and Glide files Mar 28, 2016
@calavera
Copy link
Contributor Author

@prashantv I've signed the CLA already and added the Glide files.

Dockerfile Outdated
@@ -0,0 +1,13 @@
FROM golang:1.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you think it's worth using the alpine image to make this smaller?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I had to install git and change the tar command, but the resulting image should still be smaller.

@prashantv
Copy link
Contributor

lgtm, just a couple of small questions

Signed-off-by: David Calavera <david.calavera@gmail.com>
@prashantv
Copy link
Contributor

Thanks @calavera!

@prashantv prashantv merged commit ece2ead into uber-archive:master Mar 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants