-
Notifications
You must be signed in to change notification settings - Fork 241
Add dockerfile and Glide files #39
Conversation
|
I've been using Godep for vendoring and it's been working quite well. Do you like bmizerany/vendor better? |
|
It's much more simple to use since it leaves all the dependency loading to Go's new vendoring |
|
Cool! |
|
Thanks for the change @calavera. The docker file seems great. A couple of things:
|
Signed-off-by: David Calavera <david.calavera@gmail.com>
4036c99 to
ae306e3
Compare
|
@prashantv I've signed the CLA already and added the Glide files. |
Dockerfile
Outdated
| @@ -0,0 +1,13 @@ | |||
| FROM golang:1.6 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it's worth using the alpine image to make this smaller?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, I had to install git and change the tar command, but the resulting image should still be smaller.
|
lgtm, just a couple of small questions |
Signed-off-by: David Calavera <david.calavera@gmail.com>
|
Thanks @calavera! |
Hi!
I added a couple of changes to the project:
a docker container using
docker run uber/go-torch go-torch ...