This repository was archived by the owner on Jul 11, 2022. It is now read-only.
Implement tchannel crossdock tests #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossdock/server/serializer.py
Outdated
|
|
||
| def downstream_to_json(d): | ||
| s = {} | ||
| def join_trace_request_to_json(d, s): |
Member
There was a problem hiding this comment.
please use readable variable names
crossdock/server/server.py
Outdated
| @tchannel.thrift.register(service.TracedService, method='startTrace') | ||
| @tornado.gen.coroutine | ||
| def start_trace(request): | ||
| raise UnimplementedEndpointException("tchannel startTrace endpoint not implemented") |
Member
There was a problem hiding this comment.
just don't add this endpoint to begin with, tchannel will throw some exception automatically. And we won't need UnimplementedEndpointException
Member
|
Q: somewhat suspicious about coverage numbers not changing at all. Are the crossdock files being tested? |
crossdock/server/server.py
Outdated
| @tchannel.thrift.register(service.TracedService, method='joinTrace') | ||
| @tornado.gen.coroutine | ||
| def join_trace(request): | ||
| jtr = request.body.request if request.body.request else None |
Member
There was a problem hiding this comment.
nit: request.body.request or None
crossdock/server/serializer.py
Outdated
| a == 'type_spec'] | ||
|
|
||
|
|
||
| def obj_to_json(obj): |
crossdock/docker-compose.yml
Outdated
| go: | ||
| image: jaegertracing/xdock-go | ||
| # TODO Use the master branch once this branch is merged | ||
| image: jaegertracing/xdock-go:upgrade-crossdock-tests-for-native-opentracing-in-tchannel |
Member
There was a problem hiding this comment.
the Go repo has been upgraded, you can use the latest image now (rm the tag ^^^)
Member
|
LGTM Pull the latest Go img, and |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.