Skip to content
This repository was archived by the owner on Jul 11, 2022. It is now read-only.

Update idl #23

Merged
black-adder merged 4 commits into from
Oct 31, 2016
Merged

Update idl #23

black-adder merged 4 commits into from
Oct 31, 2016

Conversation

@black-adder
Copy link
Contributor

@black-adder black-adder commented Oct 28, 2016

No description provided.

@black-adder black-adder reopened this Oct 28, 2016
@coveralls
Copy link

coveralls commented Oct 28, 2016

Coverage Status

Coverage remained the same at 90.216% when pulling 80d364f on update_idl into a5af184 on master.

@black-adder
Copy link
Contributor Author

black-adder commented Oct 28, 2016

The thrift generated python code is pretty fragile and requires that the thrift is defined in a certain order. Once jaeger-idl lands, I'll update this diff

@coveralls
Copy link

coveralls commented Oct 31, 2016

Coverage Status

Coverage remained the same at 90.216% when pulling 6ef33cd on update_idl into a5af184 on master.

@black-adder black-adder merged commit a2c08ae into master Oct 31, 2016
@black-adder black-adder deleted the update_idl branch October 31, 2016 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@vprithvi vprithvi vprithvi approved these changes

@yurishkuro yurishkuro yurishkuro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@black-adder @coveralls @vprithvi @yurishkuro