This repository was archived by the owner on Jul 11, 2022. It is now read-only.
Change sampler api #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Oct 29, 2016
| assert sampler.tags == { | ||
| 'sampler.type': 'probabilistic', | ||
| 'sampler.param': DEFAULT_SAMPLING_PROBABILITY, | ||
| } |
Member
There was a problem hiding this comment.
any reason we're not checking this anymore? E.g. in L167
yurishkuro
reviewed
Oct 29, 2016
tests/test_sampler.py
Outdated
| mock_time.side_effect = lambda: ts + 0.25 | ||
| assert not sampler.is_sampled(0), \ | ||
| 'not enough time passed for full item' | ||
| sampled, tags = sampler.is_sampled(0) |
Member
There was a problem hiding this comment.
if not using returned tags, use _
yurishkuro
approved these changes
Oct 29, 2016
Member
yurishkuro
left a comment
yurishkuro
left a comment
There was a problem hiding this comment.
lgtm aside from a couple nits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.