Skip to content
This repository was archived by the owner on Jul 11, 2022. It is now read-only.

Conversation

@yurishkuro
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 78.36% when pulling 6d7e3ea on back-to-span-context into ede24fa on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 78.36% when pulling d1c0c5b on back-to-span-context into ede24fa on master.

@coveralls
Copy link

coveralls commented Jul 13, 2016

Coverage Status

Coverage increased (+0.8%) to 78.36% when pulling 44934a8 on back-to-span-context into ede24fa on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 78.36% when pulling 44934a8 on back-to-span-context into ede24fa on master.


def local_ip():
"""Get the local network IP of this machine"""
ip = socket.gethostbyname(socket.gethostname())
Copy link
Contributor

@thepaulm thepaulm Jul 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code causes pain right now in its current instantiation in tchannel. Lot's of laptops fail calls to socket.gethostname() because of ad-hoc ephemeral nature of the their hostname from the wifi. It's become common practice for devs to hard code their hostname and then add it to their /etc/hosts file to make this work.

I'd rather not have people who are approaching this code for the first time run into this. Can we perhaps do something like this:

try:
ip = socket.gethostbyname(socket.gethostname())
except:
ip = socket.gethostbyname('localhost')

@thepaulm
Copy link
Contributor

Other than my request about the local_ip() function, this looks great!

@yurishkuro yurishkuro mentioned this pull request Jul 13, 2016
@yurishkuro yurishkuro force-pushed the back-to-span-context branch from 44934a8 to d6e3ca0 Compare July 13, 2016 22:47
@coveralls
Copy link

Coverage Status

Coverage increased (+1.5%) to 79.113% when pulling 5ec2f68 on back-to-span-context into ede24fa on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 84.486% when pulling 8c7140e on back-to-span-context into cd7ceb0 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 84.486% when pulling 9d4cdc7 on back-to-span-context into cd7ceb0 on master.

@coveralls
Copy link

coveralls commented Aug 7, 2016

Coverage Status

Coverage increased (+0.3%) to 84.486% when pulling 899e1f8 on back-to-span-context into cd7ceb0 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 84.486% when pulling 24225f5 on back-to-span-context into cd7ceb0 on master.

@yurishkuro yurishkuro changed the title Upgrade to opentracing 2.0 with SpanContext Upgrade to OpenTracing 1.1 with SpanContext Aug 8, 2016
@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Coverage increased (+0.3%) to 84.486% when pulling 66427f2 on back-to-span-context into cd7ceb0 on master.

@yurishkuro yurishkuro merged commit ab343b3 into master Aug 8, 2016
@yurishkuro yurishkuro deleted the back-to-span-context branch February 20, 2017 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants