(PXP-7097) Add optional alternate TopBar profile menu #759
Conversation
|
is this thing (and the accompanying CSS changes) deployed anywhere so we can take a look? |
@mfshao waiting on uc-cdis/gitops-qa#1051 checks to finish, and then we'll deploy this version there :) |
great! thanks it would be easier if you put all these changes locally into your dev env so we can see it without waiting for jenkins |
| isActive={this.isActive('/identity')} | ||
| onActiveTab={() => this.props.onActiveTab('/identity')} | ||
| /> | ||
| </Link> |
There was a problem hiding this comment.
I thought for this part there were some inconsistence in the design. Have we made a dicision that whether we display only a single icon or icon + username after user has logged in
If we decide to keep only a single icon, can you adjust the placement of the popover so the arrow gets pointed to the icon?
There was a problem hiding this comment.
Either option is feasible, we'll have to put that one up to the team. Pushing a commit with correct placement now, that was just a temporary change that slipped through during experimentation.
Jira Ticket: PXP-7097
New Features
TopBarcomponent for handling user profile and logout options, opt-in via configcomponents.topBar.useProfileDropdown: trueDeployment changes
qa-midrcis only env using the new feature flag. These changes should be deployed alongside each other to production, but nothing will break if done separately.