(PXP-6540): Feat/explorer download formats #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you deploy this to somewhere we can test? |
mfshao
reviewed
Jan 12, 2021
There was a problem hiding this comment.
Can you add margin-right: 10px; to the stylesheet that is styling explorer-button-group__dropdown to make the button into the right position?
Also you need to update your local package.json to use the guppy from your GH branch and commit in the updated lock file. Otherwise the portal will not work properly in your dev env because it is not using the new Guppy component. For now if I click on TSV button in your dev env I can only get an error msg in console
|
Suggest to add a brief sentence to show that we added a few new explorer button types to the PR description as |
This was referenced Jan 21, 2021
Merged
Merged
This was referenced May 6, 2021
This was referenced Jun 10, 2021
This was referenced Aug 31, 2021
Merged
This was referenced Sep 13, 2021
This was referenced Sep 20, 2021
This was referenced Mar 18, 2022
This was referenced Apr 1, 2022
Closed
This was referenced Dec 19, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Guppy for remainder of PXP-6540 changes.
New Features
Deployment Changes
portal_config.mdfor an example.