-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PXP-4319 Feat/cert audit log #738
Conversation
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Pull Request Test Coverage Report for Build 8197
💛 - Coveralls |
This pull request introduces 15 alerts when merging c09b013 into c7562d1 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also, do we know what the resources_granted
and message
columns are on the application
table? These triggers won't record changes to those
This pull request fixes 15 alerts when merging 9ef01af into b3927b0 - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 looks good now!
For posterity: In process_cert_audit()
, joining on [OLD, NEW].application_id
instead of [OLD, NEW].id
(certificate id) because in the DELETE
case, there is no more certificate row with OLD.id
, so nothing would get added to the logs. The point of the JOIN
is just to get to the User.id
and User.username
.
This PR is a part of https://ctds-planx.atlassian.net/browse/PXP-4319
Get a trigger function for
certificate
table, to record when a user has submitted a ToU/PP certThis PR denpends on
userdatamodel
PR uc-cdis/userdatamodel#67Improvements
certificate
table, to record when a user has submitted a ToU/PP certDependency updates