Swap two arguments to resolve bug #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Related issue**: N/A
**Type of change**: bug fix
**Impact**: other
**Release Notes**
The string of path for "-ip-vivado-tcls" could be empty ("")
For example, run "make SUB_PROJECT=arty bitstream" will get errors due the argument parsing in [prologue.tcl](https://github.com/sifive/fpga-shells/blob/d4b3878e4f5cf5c4621dbfe9b0bda1ed0dd3b995/xilinx/common/tcl/prologue.tcl)
Swaping the two arguments can resolve bug.
|
@jamesdunn Can you confirm this issue? How did this work in the past? |
|
For your information, the version of our Vivado tools is 2021.1 |
|
I don't see this error on my end (running |
Hi @abejgonzalez , above is the error log I got when I try on Vivado 2020.1. You can notice that the argument for "-ip-vivado-tcls" in the Vivado command is empty. Then, it seems that prologue.tcl will take "-board" as the argument for "-ip-vivado-tcls" and then find an unknown option "arty". |
|
I understand the issue, I'm just wondering why this is breaking on your end vs. ours. I'm wondering if this issue is just related to Vivado 2020.1 or if this is subject to a different issue. Can you check running on a different Vivado version? |
I retry the procedure with Vivado 2021.1 and the problem is resolved. It seems that the problem is related to the Vivado Tcl interpreter. I am not sure whetherd the Makefile should be adjusted in case that some users use the old version of Vivado? |
|
I guess for now we can switch things around... but in general this shouldn't be an issue... I'll try to see if I have a Vivado 2020.1 laying around to try out next week. Otherwise, I'll go ahead and approve/merge this. |
|
Sure! Maybe indicating the suggested version of Vivado is another solution without changing the Makfile. ^_^ |
abejgonzalez
approved these changes
Aug 30, 2021
|
Thanks for the contribution! |
|
Hi @abejgonzalez and @jamesdunn , I modifed the file prologue.tcl in my local project to properly parse the argument of strings with spaces in the string and now it can work with Vivado 2020.1. The problem might be caused by the function definition of "lassign" in Vivado 2020 Tcl parser. I am not sure whether I should update the Tcl file since the problem is fixed in Vivado 2021. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Type of change: bug fix
Impact: other
Release Notes
The string of path for "-ip-vivado-tcls" could be empty ("")
For example, run "make SUB_PROJECT=arty bitstream" will get errors due to the argument parsing in prologue.tcl since there is no generated file like "XXX.vivado.tcl " in the working directory.
Swaping the two arguments can resolve bug.