Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use netcdf quantization #1990

Merged
merged 18 commits into from
Nov 27, 2023

Conversation

DusanJovic-NOAA
Copy link
Collaborator

@DusanJovic-NOAA DusanJovic-NOAA commented Nov 9, 2023

PR Author Checklist:

  • I have linked PR's from all sub-components involved in section below.

  • I am confirming reviews are completed in ALL sub-component PR's.

  • I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:

  • I have added the list of all failed regression tests to "Anticipated changes" section.

  • I have filled out all sections of the template.

Description

This PR adds new configuration parameters which can be used to enable the netcdf quantization (lossy compression)
Two new (optional) model_configure parameters are: quantize_mode, quantize_nsd. The quantize_mode is a string which can have values 'quantize_bitgroom', 'quantize_granularbr' or 'quantize_bitround'., and quantize_nsd is number of significant digits. See documentation here.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Closes #1929
Closes #1575
Closes #1615

Subcomponent Pull Requests

NOAA-EMC/fv3atm/pull/718

Blocking Dependencies

Subcomponents involved:

  • AQM
  • CDEPS
  • CICE
  • CMEPS
  • CMakeModules
  • FV3
  • GOCART
  • HYCOM
  • MOM6
  • NOAHMP
  • WW3
  • stochastic_physics
  • none

Anticipated Changes

Input data

  • No changes are expected to input data.
  • Changes are expected to input data:
    • New input data.
    • Updated input data.

Regression Tests:

  • No changes are expected to any regression test.
  • Changes are expected to the following tests:
Tests effected by changes in this PR:
  • control_wrtGauss_netcdf_parallel
  • control_wrtGauss_netcdf_parallel_debug

Libraries

  • Not Needed
  • Needed
    • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
    • Add issue link from JCSDA/spack-stack following this item
Code Managers Log
  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
  • Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
    • N/A

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Cheyenne
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
    • Completed
  • opnReqTest
    • N/A
    • Log attached to comment

@BrianCurtis-NOAA
Copy link
Collaborator

@DusanJovic-NOAA The RegressionTests_Hera.log you have shows comparison against your own REGRESSIONTESTS directory. Do you have one that shows the two tests failing against develop baselines?

@BrianCurtis-NOAA BrianCurtis-NOAA added Baseline Updates Current baselines will be updated. Incomplete This PR does not have all required information. Please see PR Author checklist. labels Nov 9, 2023
@DusanJovic-NOAA
Copy link
Collaborator Author

RegressionTests_hera.log

Hera log file against current baseline.

@BrianCurtis-NOAA BrianCurtis-NOAA added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. and removed Incomplete This PR does not have all required information. Please see PR Author checklist. labels Nov 13, 2023
@jkbk2004
Copy link
Collaborator

@DusanJovic-NOAA We can start working on this pr. If you are available, can you sync up branch?

@zach1221 zach1221 added the jenkins-ci Jenkins CI: ORT build/test on docker container label Nov 24, 2023
@jkbk2004
Copy link
Collaborator

Regression tests run ok with this pr on RDHPCS sides. @BrianCurtis-NOAA @junwang-noaa FYI

@BrianCurtis-NOAA
Copy link
Collaborator

Regression tests run ok with this pr on RDHPCS sides. @BrianCurtis-NOAA @junwang-noaa FYI

All set for WCOSS2 Systems

@epic-cicd-jenkins
Copy link
Collaborator

Jenkins-ci ORTs passed

@zach1221
Copy link
Collaborator

zach1221 commented Nov 26, 2023

The baselines create fine, but I continue to receive failures on Hercules when attempting to match against the atmf000.nc file, on Hercules.
image

@jkbk2004
Copy link
Collaborator

File are identical. It's nccmp hiccups. If I keep submitting those two failed cases, They run and compare ok. I think random system behavior.

@jkbk2004
Copy link
Collaborator

We will monitor the functionality of nccmp on hercules in coming PRs. BTW, we can move on to merge this pr.

@zach1221
Copy link
Collaborator

@DusanJovic-NOAA fv3atm PR #718 has been merged. Please revert changes to the git module url and update the fv3atm hash.
Hash: NOAA-EMC/fv3atm@65c6017

@zach1221 zach1221 merged commit f6918a1 into ufs-community:develop Nov 27, 2023
@DusanJovic-NOAA DusanJovic-NOAA deleted the nc_quantize branch November 28, 2023 13:00
@DusanJovic-NOAA
Copy link
Collaborator Author

The baselines create fine, but I continue to receive failures on Hercules when attempting to match against the atmf000.nc file, on Hercules. image

Can you please copy/paste text next time instead of screenshot image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. jenkins-ci Jenkins CI: ORT build/test on docker container Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
7 participants