-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to use netcdf quantization #1990
Conversation
@DusanJovic-NOAA The RegressionTests_Hera.log you have shows comparison against your own REGRESSIONTESTS directory. Do you have one that shows the two tests failing against develop baselines? |
Hera log file against current baseline. |
@DusanJovic-NOAA We can start working on this pr. If you are available, can you sync up branch? |
Regression tests run ok with this pr on RDHPCS sides. @BrianCurtis-NOAA @junwang-noaa FYI |
All set for WCOSS2 Systems |
Jenkins-ci ORTs passed |
File are identical. It's nccmp hiccups. If I keep submitting those two failed cases, They run and compare ok. I think random system behavior. |
We will monitor the functionality of nccmp on hercules in coming PRs. BTW, we can move on to merge this pr. |
@DusanJovic-NOAA fv3atm PR #718 has been merged. Please revert changes to the git module url and update the fv3atm hash. |
PR Author Checklist:
I have linked PR's from all sub-components involved in section below.
I am confirming reviews are completed in ALL sub-component PR's.
I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
RegressionTests_hera.log
I have added the list of all failed regression tests to "Anticipated changes" section.
I have filled out all sections of the template.
Description
This PR adds new configuration parameters which can be used to enable the netcdf quantization (lossy compression)
Two new (optional) model_configure parameters are: quantize_mode, quantize_nsd. The
quantize_mode
is a string which can have values 'quantize_bitgroom', 'quantize_granularbr' or 'quantize_bitround'., andquantize_nsd
is number of significant digits. See documentation here.Linked Issues and Pull Requests
Associated UFSWM Issue to close
Closes #1929
Closes #1575
Closes #1615
Subcomponent Pull Requests
NOAA-EMC/fv3atm/pull/718
Blocking Dependencies
Subcomponents involved:
Anticipated Changes
Input data
Regression Tests:
Tests effected by changes in this PR:
Libraries
Code Managers Log
Testing Log: