Skip to content
This repository was archived by the owner on Sep 7, 2018. It is now read-only.

Conversation

luisvt
Copy link

@luisvt luisvt commented Jul 8, 2016

  • upgrade angular version to ^1.5.7
  • use es6 for gulpfile
  • use node_modules instead bower components for angular dependencies
  • use gulp-tsc instead gulp-typescript
  • add dist folder to distribute js files
  • remove .tmp folder
  • use node_js 6.1 instead 0.10 in .travis.yml
  • add .npmignore file to avoid publishing development files (gulp, tasks, tests) files

@coveralls
Copy link

Coverage Status

Coverage decreased (-43.9%) to 56.098% when pulling 379b03d on luisvt:master into a2e7afa on ulfryk:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-43.9%) to 56.098% when pulling b63bac8 on luisvt:master into a2e7afa on ulfryk:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-43.9%) to 56.098% when pulling b63bac8 on luisvt:master into a2e7afa on ulfryk:master.

* upgrade angular version to ^1.5.7
* use es6 for gulpfile
* use node_modules instead bower components for angular dependencies
* use gulp-tsc instead gulp-typescript
* add dist folder to distribute js files
* remove .tmp folder
* use node_js 6.1 instead 0.10 in .travis.yml
* add .npmignore file to avoid publishing development files (gulp, tasks, tests) files
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e2f3c48 on luisvt:master into a2e7afa on ulfryk:master.

@@ -1,6 +1,6 @@
language: node_js
node_js:
- "0.10"
- "6.1"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change it to 5

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason to do that?

@ulfryk
Copy link
Owner

ulfryk commented Jul 14, 2016

Great Job - just few remarks.

And one more thing:

add dist folder to distribute js files

place there also .d.ts files :)

@luisvt
Copy link
Author

luisvt commented Jul 14, 2016

I think we don't need to generate .d.ts files if we put js and ts files in the same folder.

changes:
* add tsconfig.json
* change back to gulp-typescript
* add noEmitHelpers to tsconfig.json
* add dependency ts-helpers
@luisvt luisvt closed this Jul 15, 2016
@ulfryk
Copy link
Owner

ulfryk commented Jul 15, 2016

@luisvt - actually I liked this change (just a bit tuned to my preferences) - maybe you can finish it in this repo?

@luisvt
Copy link
Author

luisvt commented Jul 15, 2016

yes, sorry. The problem was that I was using master branch, I will recreate the merge request with a different branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants