This repository was archived by the owner on Sep 7, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
upgrade angular version and add some other code #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisvt
commented
Jul 8, 2016
- upgrade angular version to ^1.5.7
- use es6 for gulpfile
- use node_modules instead bower components for angular dependencies
- use gulp-tsc instead gulp-typescript
- add dist folder to distribute js files
- remove .tmp folder
- use node_js 6.1 instead 0.10 in .travis.yml
- add .npmignore file to avoid publishing development files (gulp, tasks, tests) files
* upgrade angular version to ^1.5.7 * use es6 for gulpfile * use node_modules instead bower components for angular dependencies * use gulp-tsc instead gulp-typescript * add dist folder to distribute js files * remove .tmp folder * use node_js 6.1 instead 0.10 in .travis.yml * add .npmignore file to avoid publishing development files (gulp, tasks, tests) files
@@ -1,6 +1,6 @@ | |||
language: node_js | |||
node_js: | |||
- "0.10" | |||
- "6.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change it to 5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any reason to do that?
Great Job - just few remarks. And one more thing:
place there also |
I think we don't need to generate |
changes: * add tsconfig.json * change back to gulp-typescript * add noEmitHelpers to tsconfig.json * add dependency ts-helpers
@luisvt - actually I liked this change (just a bit tuned to my preferences) - maybe you can finish it in this repo? |
yes, sorry. The problem was that I was using master branch, I will recreate the merge request with a different branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.