Repository navigation
Make ElementPickerValueConverter public, consistent with other property value converters #24567
Closed
glombek
started this conversation in
Features and ideas
Replies: 1 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
ElementPickerValueConverterisinternal sealed, from 18.0.0 through 19.0.0-beta1. It's the only internal converter inUmbraco.CoreandUmbraco.Infrastructure. Every other built-in property value converter is public, including the new 19 pickers such asMultipleDocumentPickerValueConverter.Because it's internal, packages can't:
builder.PropertyValueConverters().Remove<ElementPickerValueConverter>()That's how packages like SuperValueConverters return Models Builder types for pickers. For example, a picker that only allows
MyElementreturnsIEnumerable<MyElement>, notIEnumerable<IPublishedElement>. With the Element Picker, that currently needs reflection.Was it made internal on purpose? If not, could it be made public, ideally before 19.0.0 is released?
All reactions