Profile: Corrected misleading button label

[OskarKruger]

Description

Changed description for profile button label, as "open/close profile" was misleading since interacting with this button won't close the menu as it appears as an overlay.
Changed the object name also to ensure clarity.

[leekelleher]

@OskarKruger Thanks for tackling this one, the "open/close" label has been confusing for many! I've left a few comments...

[OskarKruger]

Hi @leekelleher
Thanks for the feedback!

I made some corrections with your notes.
Reverted the XML configs to original, changed the localization key to simplify it even more into just profileOptions, and updated the call.
Since this is only done for major releases, should this be a candidate for v17 then?

[leekelleher]

Thanks @OskarKruger! 💪

Since this is only done for major releases, should this be a candidate for v17 then?

We've good to add in new localization keys in the minor releases, so this is fine for 16.3.

The removal should be inline with our deprecation policy, which is "mark as deprecated, then remove the version after next", which would be v18 in this case. (This is to give 3rd-party extension developers time to update their code). Although, this might feel overkill for a localization key. 😬 So I wouldn't worry too much about removing the unused localization keys yet, (we'll tackle that closer to v18).

[OskarKruger]

Cheers @leekelleher!
That makes sense to me also to respect that policy. Let me know what changes could be made from here to stay in line with naming conventions etc :)

[leekelleher]

@OskarKruger If you revert the removal of the openCloseBackofficeProfileOptions localization keys, then this PR is good to merge in! 🚀

[leekelleher]

Looking good, thank you @OskarKruger! 🚀