Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app.ts): defineApp undefined #10436

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix(app.ts): defineApp undefined #10436

merged 1 commit into from
Feb 7, 2023

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Feb 6, 2023

#10412 发现了更多循环依赖问题,其中 defineApp 在 max 中 app.ts 使用会崩溃 undefined ,所以把 #9708 这个 PR 一部分致命的问题先拆出来解掉。

@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
umi ⬜️ Ignored (Inspect) Feb 6, 2023 at 5:04PM (UTC)

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 29.26% // Head: 29.34% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (1d4eb62) compared to base (0c568fa).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10436      +/-   ##
==========================================
+ Coverage   29.26%   29.34%   +0.07%     
==========================================
  Files         445      445              
  Lines       13041    12980      -61     
  Branches     3186     3056     -130     
==========================================
- Hits         3817     3809       -8     
+ Misses       8615     8533      -82     
- Partials      609      638      +29     
Impacted Files Coverage Δ
...kages/preset-umi/src/features/tmpFiles/tmpFiles.ts 0.00% <0.00%> (ø)
packages/testing/src/index.ts 0.00% <0.00%> (ø)
packages/umi/src/test.ts 47.22% <50.00%> (+0.16%) ⬆️
...ages/bundler-webpack/src/config/javaScriptRules.ts 74.24% <0.00%> (-0.05%) ⬇️
packages/mfsu/src/moduleGraph.ts 99.28% <0.00%> (-0.01%) ⬇️
codemod/src/checker.ts 0.00% <0.00%> (ø)
packages/server/src/ssr.ts 0.00% <0.00%> (ø)
codemod/src/appJSUpdater.ts 0.00% <0.00%> (ø)
packages/umi/src/cli/cli.ts 0.00% <0.00%> (ø)
codemod/src/runner/config.ts 0.00% <0.00%> (ø)
... and 45 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc sorrycc merged commit 8e1b365 into umijs:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants