perf: cnpm and tnpm are supported #10452
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportBase: 29.67% // Head: 29.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #10452 +/- ##
==========================================
- Coverage 29.67% 29.59% -0.09%
==========================================
Files 445 446 +1
Lines 13013 13050 +37
Branches 3069 3080 +11
==========================================
Hits 3862 3862
- Misses 8511 8545 +34
- Partials 640 643 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
txp1035
changed the title
| await installWithNpmClient({ | ||
| npmClient: opts.npmClient as NpmClient, | ||
| options: { dev: true, names: [name] }, | ||
| }); |
There was a problem hiding this comment.
这里的实现思路需要调整下。先修改 package.json 增加依赖信息，然后在执行 installWithNpmClient，所以 installWithNpmClient 和之前保持一致，不需要改。
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
| svg = await loadNodeIcon(opts.collect, opts.icon, { | ||
| warn, | ||
| addXmlNs: false, | ||
| autoInstall: false, | ||
| ...opts.iconifyOptions, | ||
| autoInstall: autoInstall |
There was a problem hiding this comment.
把 autoInstall 的自定义方法内容提到外层（icons.ts）里吧，把 api 插进去之后 generateSvgr 就不那么纯粹了。
|
这个功能我希望尽快收尾了，所以先合了，合完之后我再调整下。 |
Close #10442
进展：图标库已发版，支持自定义安装
我想的是把现有的安装包的工具扩展下，可以支持单独安装同时不影响之前的。