Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iife): improve esbuild iife #10675

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Mar 3, 2023

改善和修复一些 esbuild minify iife 的问题。

cc @xierenyuan

@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
umi ⬜️ Ignored (Inspect) Mar 3, 2023 at 4:15PM (UTC)

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (8d7cfbf) 28.98% compared to head (9ede91a) 28.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10675      +/-   ##
==========================================
- Coverage   28.98%   28.95%   -0.03%     
==========================================
  Files         458      458              
  Lines       13615    13627      +12     
  Branches     3187     3193       +6     
==========================================
  Hits         3946     3946              
- Misses       8993     9002       +9     
- Partials      676      679       +3     
Impacted Files Coverage Δ
...es/bundler-webpack/src/plugins/EsbuildMinifyFix.ts 4.83% <0.00%> (-1.05%) ⬇️
packages/plugins/src/request.ts 0.00% <ø> (ø)
...ackages/preset-umi/src/features/appData/appData.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc
Copy link
Member

sorrycc commented Mar 6, 2023

@xierenyuan review 下哈。

@sorrycc sorrycc requested a review from xierenyuan March 6, 2023 01:51
@sorrycc sorrycc merged commit 5d3009b into umijs:master Mar 6, 2023
MaxCDon pushed a commit to MaxCDon/umi that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants