@umijs/ui import 菜单页面开发 #10686
Merged
@umijs/ui import 菜单页面开发 #10686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Size Change: 0 B Total Size: 9.62 MB ℹ️ View Unchanged
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #10686 +/- ##
=======================================
Coverage 28.89% 28.89%
=======================================
Files 458 458
Lines 13655 13655
Branches 3200 3200
=======================================
Hits 3946 3946
Misses 9027 9027
Partials 682 682 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fz6m
reviewed
Mar 7, 2023
| @@ -0,0 +1,3 @@ | |||
| export { ViewButton } from '@/pages/imports/components/ViewButton'; | |||
| export { ViewChart } from '@/pages/imports/components/ViewChart'; | |||
There was a problem hiding this comment.
这么在一处 re export 很容易造成循环依赖，每次都是全部索引，说不定哪个链路上的的反过来导一下就循环了，不建议在一处 re export 。
| }, | ||
| { | ||
| value: 'chart', | ||
| icon: 'pie-chart-outlined', |
There was a problem hiding this comment.
本次提交的代码里建议多用枚举，不要有 copy 字符串的地方。
| @@ -13,7 +13,7 @@ interface IRoute { | |||
| __isJSFile?: boolean; | |||
| } | |||
|
|
|||
| interface IAppData { | |||
| export interface IAppData { | |||
| cwd: string; | |||
There was a problem hiding this comment.
这个 useAppData 的类型，现在 umi 框架内也是缺的，这次好不容易写出来了，就辛苦一起帮着完善下框架内的 useAppData 的 type 吧 🌹，这样这部分就可以删了
| }); | ||
|
|
||
| return [...acc, ...edges]; | ||
| }, []); |
There was a problem hiding this comment.
这个地方的索引图建议去掉 xxx/.umi/xxx 下面的，因为这里面全是循环引用，展示出来没有意义，开发者也不关心这些临时文件。
另外美观性方面，可以参考：https://next-route-visualizer.vercel.app/
|
先合了，改进的点走单独的 PR 吧。 |
sorrycc
approved these changes
Mar 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
list:
chart: 基于 antv/g6
