fix: page not prerendered should not hydrate #10724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
PeachScript
reviewed
Mar 10, 2023
fz6m
reviewed
Mar 10, 2023
| }); | ||
|
|
||
| api.addRuntimePlugin(() => { | ||
| return [withTmpPath({ api, path: 'exportStaticRuntimePlugin.ts' })]; |
There was a problem hiding this comment.
手拼下，不要这么用 withTmpPath ，就幽灵依赖了：
return [winPath(join(api.paths.absTmpPath, `plugin-${api.plugin.key}` , 'exportStaticRuntimePlugin.ts'))]或者把 withTmpPath 在 preset-umi/src/utils 也 copy 一份。
| import { getMarkup } from '@umijs/server'; | ||
| import { lodash, logger, winPath } from '@umijs/utils'; | ||
| import assert from 'assert'; | ||
| import { dirname, join, relative } from 'path'; | ||
| import { Mustache } from 'umi/plugin-utils'; |
There was a problem hiding this comment.
从 @umijs/utils 里导入 Mustache ，这是运行时的写法，在 node 环境不要这么用。
sorrycc
approved these changes
Mar 14, 2023
|
感谢 PR！如果有兴趣一起参与维护 Umi，可加入我们的 Umi Contributor 群。加入方式是先用钉钉扫下方二维码加我钉钉，记得注明 github id，然后我会拉你到群里。 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
当前在
exportStatic中配置了prerender: false的页面仍然会在客户端注水，因为 dom 不匹配会导致 SSR 警告转为 CSR。比如 antd 官网的 demo 页：https://ant-design.antgroup.com/~demos/components-button-demo-basic
Solution
配置了
prerender: false的页面直接客户端渲染，不走注水逻辑。