-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mfsu): 🐛 resolve deps from importer should prioritise to cwd #10804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
// resolve from importer's dir priority to cwd | ||
const contexts = this.importer | ||
? [dirname(this.importer), this.cwd] | ||
: [this.cwd]; | ||
|
||
// don't need to handle alias here | ||
// it's already handled by babel plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这是一个Dep
类的代码补丁。以下是我的建议:
- 没有明显的错误风险,看起来代码可以正常工作。
- 重新排序了import声明,使其更易读。
- 可以考虑一些优化,例如使用可选链操作符来避免对null或undefined进行不必要的检查。
希望这可以帮助你。
stormslowly
changed the title
fix: 🐛 resolve from importer should prioritise
fix(mfsu): 🐛 resolve deps from importer should prioritise to cwd
Mar 21, 2023
sorrycc
approved these changes
Mar 21, 2023
Size Change: -6 B (0%) Total Size: 9.73 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.