Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setNodeprecation): update the reference url #10852

Merged
merged 2 commits into from
Mar 26, 2023

Conversation

zxf4399
Copy link
Contributor

@zxf4399 zxf4399 commented Mar 25, 2023

学习 umi 源码的时候有这段代码:

image

点进 🔗 发现对应的代码是这一行

image

有点疑惑,搜了下这个文件发现 95 行才有这个代码

image

翻了下历史记录发现这个引用 🔗 是这个 commit 带来的

image

推测那个时候的 77 行是现在的 95 行

@vercel
Copy link

vercel bot commented Mar 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
umi ⬜️ Ignored (Inspect) Mar 26, 2023 at 0:49AM (UTC)

@fz6m
Copy link
Contributor

fz6m commented Mar 25, 2023

换个 permalink 永久链接吧。

@zxf4399
Copy link
Contributor Author

zxf4399 commented Mar 26, 2023

换个 permalink 永久链接吧。

已更新

@sorrycc sorrycc merged commit c5f3dc7 into umijs:master Mar 26, 2023
@github-actions
Copy link

感谢 PR!如果有兴趣一起参与维护 Umi,可加入我们的 Umi Contributor 群。加入方式是先用钉钉扫下方二维码加我钉钉,记得注明 github id,然后我会拉你到群里。

@zxf4399 zxf4399 deleted the fix/2023-03-25 branch March 27, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants