-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bundler-vite): unexpected assets url if configure publicPath #10928
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size Change: -53 B (0%) Total Size: 9.85 MB
ℹ️ View Unchanged
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #10928 +/- ##
=======================================
Coverage 29.27% 29.27%
=======================================
Files 478 478
Lines 14318 14317 -1
Branches 3369 3368 -1
=======================================
Hits 4191 4191
+ Misses 9405 9404 -1
Partials 722 722
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
assetsDir 不能指定成 publicPath 使用默认值
补齐下背景 从 vite 2 开始 assetsDir 就作为 join 的参数, 如果设置 publicPath 会导致 生成路径包含 publicPath 当指定CDN 的场景会有问题 https://github.com/vitejs/vite/blob/main/packages/vite/src/node/build.ts#L614