Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnpm): pnpm v8 auto upgrade deps when init project #10991

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented Apr 17, 2023

#10913 的第二步对策。

在 pnpm v8 初始化项目时,直接 up 到最新。

@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Apr 17, 2023 2:42pm

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 45.45% and no project coverage change.

Comparison is base (db3a325) 29.23% compared to head (132b837) 29.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10991   +/-   ##
=======================================
  Coverage   29.23%   29.24%           
=======================================
  Files         478      478           
  Lines       14352    14361    +9     
  Branches     3379     3382    +3     
=======================================
+ Hits         4196     4200    +4     
- Misses       9431     9436    +5     
  Partials      725      725           
Impacted Files Coverage Δ
packages/create-umi/src/index.ts 57.33% <45.45%> (-0.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript merged commit 1ef3c33 into umijs:master Apr 19, 2023
@PeachScript
Copy link
Member

@fz6m 话说这个逻辑能不能做到 installWithNpmClient 里,这样 dumi 也能直接用上

@fz6m
Copy link
Member Author

fz6m commented Apr 19, 2023

@fz6m 话说这个逻辑能不能做到 installWithNpmClient 里,这样 dumi 也能直接用上

可以,但是不能把它做成默认行为,因为这个是全量依赖升级,只出现在刚初始化完项目。但在 umi 里还有很多处是先修改了 package.json 添加依赖再运行 installWithNpmClient ,这个时候不应该全量升级依赖,所以我就没做到 installWithNpmClient 里了。

感觉目前的应用场景是初始化项目完:pnpm v8 就特殊对待一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants