Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use absolute path to types reference #11015

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Apr 21, 2023

经反馈,使用绝对路径的 ts types 引用,在使用 npm / yarn 的时候有大小写问题,所以我们跳过这些包管理器的绝对路径解析,因为他们有幽灵依赖,可以直接解析到。

from #10947

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Apr 21, 2023 8:54am

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (d94178a) 29.21% compared to head (194c024) 29.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11015      +/-   ##
==========================================
- Coverage   29.21%   29.21%   -0.01%     
==========================================
  Files         479      479              
  Lines       14384    14385       +1     
  Branches     3382     3381       -1     
==========================================
  Hits         4203     4203              
- Misses       9454     9455       +1     
  Partials      727      727              
Impacted Files Coverage Δ
packages/plugins/src/layout.ts 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc sorrycc merged commit 1942b05 into umijs:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants