feat(ui): 新增api.addUiMenu #11032
Merged
feat(ui): 新增api.addUiMenu #11032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
fz6m
reviewed
Apr 24, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #11032 +/- ##
==========================================
- Coverage 29.21% 29.19% -0.03%
==========================================
Files 479 479
Lines 14385 14398 +13
Branches 3381 3385 +4
==========================================
Hits 4203 4203
- Misses 9455 9468 +13
Partials 727 727
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sorrycc
approved these changes
Apr 25, 2023
|
感谢 PR！如果有兴趣一起参与维护 Umi，可加入我们的 Umi Contributor 群。加入方式是先用钉钉扫下方二维码加我钉钉，记得注明 github id，然后我会拉你到群里。 |
fz6m
reviewed
Apr 25, 2023
Comment on lines
+97
to
+102
| Object.assign(memo, { | ||
| ui: { | ||
| modules: uiModules, | ||
| }, | ||
| }); | ||
| return memo; |
There was a problem hiding this comment.
为啥要这么用，直接 memo.ui 不就好了，这样会慢 40% ，参考 benchmark 。
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.