Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support routeMode prepend & match #11323

Merged
merged 3 commits into from
Jun 29, 2023

Conversation

jaredleechn
Copy link
Contributor

@jaredleechn jaredleechn commented Jun 27, 2023

  • 新增了 qiankun.master.routes[].mode: 'match' | 'prepend'match 时仅作为匹配规则,不会作为 router 前缀
  • 修复了主子应用路由相同时,优先匹配主应用路由的 bug,可能会有 breakingChange

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Jun 29, 2023 3:04am

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (5a02489) 29.09% compared to head (7a352b6) 29.03%.

❗ Current head 7a352b6 differs from pull request most recent head 0132d80. Consider uploading reports for the commit 0132d80 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11323      +/-   ##
==========================================
- Coverage   29.09%   29.03%   -0.06%     
==========================================
  Files         483      484       +1     
  Lines       14640    14667      +27     
  Branches     3454     3460       +6     
==========================================
  Hits         4259     4259              
- Misses       9632     9657      +25     
- Partials      749      751       +2     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sorrycc sorrycc merged commit 6ca0e0e into umijs:master Jun 29, 2023
@github-actions
Copy link

感谢 PR!如果有兴趣一起参与维护 Umi,可加入我们的 Umi Contributor 群。加入方式是先用钉钉扫下方二维码加我钉钉,记得注明 github id,然后我会拉你到群里。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants