Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qiankun): master base ends with slash #11448

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Jul 24, 2023

fix #11447

master 的 base 尾部有斜线的情况,要去掉,不然多拼一个斜线,比如 /base/ + /url

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Jul 24, 2023 0:40am

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5be135f) 29.02% compared to head (acd0449) 29.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11448   +/-   ##
=======================================
  Coverage   29.02%   29.02%           
=======================================
  Files         484      484           
  Lines       14672    14672           
  Branches     3462     3462           
=======================================
  Hits         4259     4259           
  Misses       9661     9661           
  Partials      752      752           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sorrycc sorrycc merged commit 1a0bd61 into umijs:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] umi4+qiankun 主应用设置publicPath和base以后,子应用无法显示
2 participants