fix(ssr): support ant design pro ssr #11702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11702 +/- ##
==========================================
- Coverage 29.02% 28.92% -0.10%
==========================================
Files 488 485 -3
Lines 14828 14771 -57
Branches 3512 3495 -17
==========================================
- Hits 4304 4273 -31
+ Misses 9764 9739 -25
+ Partials 760 759 -1
☔ View full report in Codecov by Sentry. |
|
Size Change: +162 B (0%) Total Size: 9.89 MB
ℹ️ View Unchanged
|
fz6m
reviewed
Oct 1, 2023
fz6m
reviewed
Oct 23, 2023
| // skip dynamic route for win, because `:` is not allowed in file name | ||
| (!IS_WIN || !route.path.includes('/:')) && | ||
| (!IS_WIN || !route?.path?.includes('/:')) && |
There was a problem hiding this comment.
前面已经判断了 route?.path ，后面的判断条件就已经当做 route.path 存在了，所以可选链只需要到 route.path?.includes ，这里面写了一些冗余的可选。
| opts.helmetContext.helmet?.priority?.toString(), | ||
| opts.helmetContext.helmet?.meta?.toString(), | ||
| opts.helmetContext.helmet?.link?.toString(), | ||
| opts.helmetContext.helmet?.script?.toString(), |
There was a problem hiding this comment.
这个地方应该参照如上 comment 改一下，编译完的结果冗余代码太多了，性能很差。
|
我认为这个 PR 的代码质量存在问题，目前仓库内存在很多低质量的代码，并且被 juejin 社区等源码阅读者发文指出，不是一个好未来。 |
|
umi 升级到最新版本，在antd pro 5.20 就可以支持 ssr了嘛，antd pro 需要升级嘛 |
|
这是来自QQ邮箱的假期自动回复邮件。
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
PeachScript
added a commit
that referenced
this pull request
Nov 9, 2023
This reverts commit a830383.
PeachScript
added a commit
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.