Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: SSR模式下,多输出一份和index.html完全一致的*.html文件,用于ER场景 #11734

Merged
merged 24 commits into from
Oct 13, 2023

Conversation

gwuhaolin
Copy link
Member

@gwuhaolin gwuhaolin commented Oct 13, 2023

No description provided.

奇风 and others added 24 commits October 8, 2023 12:00
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
Co-authored-by: 咲奈Sakina <59400654+fz6m@users.noreply.github.com>
Co-authored-by: 咲奈Sakina <59400654+fz6m@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2023 6:36am

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e342e82) 28.93% compared to head (0a165a5) 28.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11734   +/-   ##
=======================================
  Coverage   28.93%   28.94%           
=======================================
  Files         485      485           
  Lines       14776    14774    -2     
  Branches     3501     3501           
=======================================
  Hits         4276     4276           
+ Misses       9740     9738    -2     
  Partials      760      760           
Files Coverage Δ
packages/preset-umi/src/features/ssr/ssr.ts 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
补充背景:exportStatic 场景下会过滤掉 *.html 以支持静态站点托管服务或 CDN,原 PR #11723 的变更可能会导致使用 dumi 的静态站点无法部署,加上该变更是与内部平台强耦合,故回滚并将其挪进内部框架中

@PeachScript PeachScript changed the title fix: 回滚SSR模式下,多输出一份和index.html完全一致的*.html文件,用于ER场景 revert: SSR模式下,多输出一份和index.html完全一致的*.html文件,用于ER场景 Oct 13, 2023
@PeachScript PeachScript merged commit 0f5f749 into umijs:master Oct 13, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants