feat: add ssr types and refactor some logic #11784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11784 +/- ##
==========================================
- Coverage 29.01% 29.00% -0.02%
==========================================
Files 488 488
Lines 14835 14841 +6
Branches 3517 3514 -3
==========================================
Hits 4304 4304
- Misses 9771 9777 +6
Partials 760 760
☔ View full report in Codecov by Sentry. |
fz6m
commented
Nov 7, 2023
| @@ -266,8 +266,9 @@ const getBrowser = ( | |||
| // use ?. since routes patched with patchClientRoutes is not exists in opts.routes | |||
| if (!isFirst && opts.routes[id]?.hasServerLoader) { | |||
| // 在有basename的情况下__serverLoader的请求路径需要加上basename | |||
| fetch((basename.endsWith('/') ? basename : basename + '/') + '__serverLoader?route=' + id, { | |||
| credentials: 'include' | |||
| const url = `${withEndSlash(basename)}'__serverLoader?route='${id}`; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
重构少量 fix: SSR withoutHTML模式下，包一层<div id="root">{app}</div> #11724 、 feature: 支持serverLoader中读取url和headers #11755 两个 PR 里不优雅的书写。
新增
serverLoader和useServerLoaderData的类型。