-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: internal history method #12389
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Walkthrough在本次更改中,主要是对 Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Size Change: 0 B Total Size: 9.9 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/preset-umi/src/features/tmpFiles/tmpFiles.ts (1 hunks)
- packages/preset-umi/templates/history.tpl (1 hunks)
Additional comments not posted (2)
packages/preset-umi/templates/history.tpl (1)
44-48
: 新增的setHistory
函数逻辑清晰,符合预期。packages/preset-umi/src/features/tmpFiles/tmpFiles.ts (1)
621-623
: 导出的setHistory
函数正确无误,符合预期。
这个需求的背景是啥啊,啥时候需要自己的 history ,做了啥 patch 吗。 |
是个微应用架构下比较黑的场景,要绑定两个应用的 history 实例,所以先不从 umi 暴露出来了 |
增加修改 history 的 api
Summary by CodeRabbit
setHistory
方法,允许用户设置历史对象。